All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: aschultz@tpip.net
Cc: pablo@netfilter.org, netdev@vger.kernel.org,
	Lionel.Gauthier@eurecom.fr, openbsc@lists.osmocom.org,
	laforge@gnumonks.org
Subject: Re: [PATCH net v2 3/3] gtp: fix cross netns recv on gtp socket
Date: Thu, 26 Jan 2017 14:22:47 -0500 (EST)	[thread overview]
Message-ID: <20170126.142247.527598780818100974.davem@davemloft.net> (raw)
In-Reply-To: <20170126151134.2892-4-aschultz@tpip.net>

From: Andreas Schultz <aschultz@tpip.net>
Date: Thu, 26 Jan 2017 16:11:34 +0100

> The use of the passed through netlink src_net to check for a
> cross netns operation was wrong. Using the GTP socket and the
> GTP netdevice is always correct (even if the netdev has been
> moved to new netns after link creation).
> 
> Remove the now obsolete net field from gtp_dev.
> 
> Signed-off-by: Andreas Schultz <aschultz@tpip.net>

Please at least compile test your submissions:

drivers/net/gtp.c: In function ‘gtp_newlink’:
drivers/net/gtp.c:677:8: error: too many arguments to function ‘gtp_encap_enable’
  err = gtp_encap_enable(dev, gtp, fd0, fd1, src_net);
        ^
drivers/net/gtp.c:659:12: note: declared here
 static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
            ^
drivers/net/gtp.c: At top level:
drivers/net/gtp.c:822:12: error: conflicting types for ‘gtp_encap_enable’
 static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
            ^
drivers/net/gtp.c:659:12: note: previous declaration of ‘gtp_encap_enable’ was here
 static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
            ^
drivers/net/gtp.c:659:12: warning: ‘gtp_encap_enable’ used but never defined
drivers/net/gtp.c:822:12: warning: ‘gtp_encap_enable’ defined but not used [-Wunused-function]
 static int gtp_encap_enable(struct net_device *dev, struct gtp_dev *gtp,
            ^
scripts/Makefile.build:299: recipe for target 'drivers/net/gtp.o' failed

      parent reply	other threads:[~2017-01-26 19:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 15:11 [PATCH net v2 0/3] various gtp fixes Andreas Schultz
2017-01-26 15:11 ` [PATCH net v2 1/3] gtp: add genl family modules alias Andreas Schultz
2017-01-26 15:34   ` Pablo Neira Ayuso
2017-01-26 15:11 ` [PATCH net v2 2/3] gtp: clear DF bit on GTP packet tx Andreas Schultz
2017-01-26 15:34   ` [PATCH net v2 2/3] gtp: clear DF bit on GTP packet txç Pablo Neira Ayuso
2017-01-26 15:11 ` [PATCH net v2 3/3] gtp: fix cross netns recv on gtp socket Andreas Schultz
2017-01-26 15:34   ` Pablo Neira Ayuso
2017-01-26 19:22   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126.142247.527598780818100974.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Lionel.Gauthier@eurecom.fr \
    --cc=aschultz@tpip.net \
    --cc=laforge@gnumonks.org \
    --cc=netdev@vger.kernel.org \
    --cc=openbsc@lists.osmocom.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.