From: Omar Sandoval <osandov@osandov.com>
To: linux-btrfs@vger.kernel.org
Cc: Chris Murphy <lists@colorremedies.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
stable@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] Btrfs: disable xattr operations on subvolume directories
Date: Wed, 25 Jan 2017 17:08:23 -0800 [thread overview]
Message-ID: <20170126010823.GB19099@vader> (raw)
In-Reply-To: <c96f9f4d14c7a40913a39856ca8f065d37113372.1485311744.git.osandov@fb.com>
On Wed, Jan 25, 2017 at 05:06:36PM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> When you snapshot a subvolume containing a subvolume, you get a
> placeholder read-only directory where the subvolume would be. These
> directory inodes have ->i_ops set to btrfs_dir_ro_inode_operations.
> Previously, this didn't include the xattr operation callbacks. The
> conversion to xattr_handlers missed this case, leading to bogus attempts
> to set xattrs on these inodes. This manifested itself as failures when
> running delayed inodes.
>
> To fix this, clear the IOP_XATTR in ->i_opflags on these inodes.
>
> Fixes: 6c6ef9f26e59 ("xattr: Stop calling {get,set,remove}xattr inode operations")
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Reported-by: Chris Murphy <lists@colorremedies.com>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Applies to v4.10-rc4. Chris, this fixes the issue for me, could you please test
> it out? Andreas, does this make sense? I'll try to cook up an xfstest for this.
>
(Sorry, accidentally resent v1, ignore this one and just look at v2).
prev parent reply other threads:[~2017-01-26 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 1:06 [PATCH] Btrfs: disable xattr operations on subvolume directories Omar Sandoval
2017-01-25 2:38 ` Omar Sandoval
2017-01-25 12:28 ` Andreas Gruenbacher
[not found] ` <CAHc6FU7ubp4-A-oF+0nuKf27QJMeG_UtQx0pjdL7uVS+UwX6uw@mail.gmail.com>
2017-01-25 23:46 ` Omar Sandoval
2017-01-26 1:06 ` [PATCH v2 0/3] " Omar Sandoval
2017-01-26 1:06 ` [PATCH v2 1/3] Btrfs: remove old tree_root case in btrfs_read_locked_inode() Omar Sandoval
2017-01-26 17:19 ` David Sterba
2017-01-26 1:06 ` [PATCH v2 2/3] Btrfs: disable xattr operations on subvolume directories Omar Sandoval
2017-01-26 17:19 ` David Sterba
2017-01-26 1:06 ` [PATCH v2 3/3] Btrfs: remove ->{get,set}_acl() from btrfs_dir_ro_inode_operations Omar Sandoval
2017-01-26 17:18 ` David Sterba
2017-01-26 23:45 ` [PATCH v2 0/3] Btrfs: disable xattr operations on subvolume directories Chris Mason
2017-01-26 1:08 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126010823.GB19099@vader \
--to=osandov@osandov.com \
--cc=agruenba@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.