From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753169AbdAZIfA (ORCPT ); Thu, 26 Jan 2017 03:35:00 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:55204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752975AbdAZIe6 (ORCPT ); Thu, 26 Jan 2017 03:34:58 -0500 Date: Thu, 26 Jan 2017 00:34:54 -0800 From: Christoph Hellwig To: Fam Zheng Cc: linux-kernel@vger.kernel.org, Paolo Bonzini , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , "Michael S. Tsirkin" , Jason Wang , "Martin K. Petersen" , stefanha@redhat.com, virtualization@lists.linux-foundation.org, Cathy Avery Subject: Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host Message-ID: <20170126083454.GA21942@infradead.org> References: <20170126034109.16144-1-famz@redhat.com> <20170126034109.16144-3-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126034109.16144-3-famz@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 11:41:09AM +0800, Fam Zheng wrote: > This implements the VIRTIO_SCSI_F_FC_HOST feature by reading the config > fields and presenting them as sysfs fc_host attributes. The config > change handler is added here because primary_active will toggle during > migration. This needs a way, way better description on why the heck we would even bother with something odd like this. Also please coordinate with Cathy's "lightweight" FC attrs for storsvcs as the code seems to be clearly following the "lead" set by Hyper-V.