All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Fam Zheng <famz@redhat.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, stefanha@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	Cathy Avery <cavery@redhat.com>
Subject: Re: [PATCH v2 2/2] virtio_scsi: Implement fc_host
Date: Thu, 26 Jan 2017 00:34:54 -0800	[thread overview]
Message-ID: <20170126083454.GA21942__30945.1866582551$1485419715$gmane$org@infradead.org> (raw)
In-Reply-To: <20170126034109.16144-3-famz@redhat.com>

On Thu, Jan 26, 2017 at 11:41:09AM +0800, Fam Zheng wrote:
> This implements the VIRTIO_SCSI_F_FC_HOST feature by reading the config
> fields and presenting them as sysfs fc_host attributes. The config
> change handler is added here because primary_active will toggle during
> migration.

This needs a way, way better description on why the heck we would
even bother with something odd like this.

Also please coordinate with Cathy's "lightweight" FC attrs for storsvcs
as the code seems to be clearly following the "lead" set by Hyper-V.

  parent reply	other threads:[~2017-01-26  8:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  3:41 [PATCH v2 0/2] virtio-scsi: Implement FC_HOST feature Fam Zheng
2017-01-26  3:41 ` Fam Zheng
2017-01-26  3:41 ` [PATCH v2 1/2] virtio_scsi: Add fc_host definitions Fam Zheng
2017-01-26  3:41 ` Fam Zheng
2017-01-26 21:49   ` Michael S. Tsirkin
2017-01-26 21:49     ` Michael S. Tsirkin
2017-01-26  3:41 ` [PATCH v2 2/2] virtio_scsi: Implement fc_host Fam Zheng
2017-01-26  3:41   ` Fam Zheng
2017-01-26  8:34   ` Christoph Hellwig
2017-01-26  8:34   ` Christoph Hellwig [this message]
2017-01-26  8:55   ` kbuild test robot
2017-01-26  8:55     ` kbuild test robot
2017-01-26 22:06   ` Michael S. Tsirkin
2017-01-26 22:06     ` Michael S. Tsirkin
2017-01-27  8:43     ` Paolo Bonzini
2017-01-27  8:43       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20170126083454.GA21942__30945.1866582551$1485419715$gmane$org@infradead.org' \
    --to=hch@infradead.org \
    --cc=cavery@redhat.com \
    --cc=famz@redhat.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.