From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbdAZJSn (ORCPT ); Thu, 26 Jan 2017 04:18:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:38356 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbdAZJSh (ORCPT ); Thu, 26 Jan 2017 04:18:37 -0500 Date: Thu, 26 Jan 2017 10:18:34 +0100 From: Michal Hocko To: ysxie@foxmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined Message-ID: <20170126091833.GC6590@dhcp22.suse.cz> References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-2-git-send-email-ysxie@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485356738-4831-2-git-send-email-ysxie@foxmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote: > From: Yisheng Xie > > Define isolate_movable_page as a static inline function when > CONFIG_MIGRATION is not enable. It should return false > here which means failed to isolate movable pages. > > This patch do not have any functional change but prepare for > later patch. I think it would make more sense to make isolate_movable_page return int and have the same semantic as __isolate_lru_page. This would be a better preparatory patch for the later work. > Signed-off-by: Yisheng Xie > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Naoya Horiguchi > CC: Vlastimil Babka > --- > include/linux/migrate.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index ae8d475..631a8c8 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new, > free_page_t free, unsigned long private, enum migrate_mode mode, > int reason) > { return -ENOSYS; } > +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode) > + { return false; } > > static inline int migrate_prep(void) { return -ENOSYS; } > static inline int migrate_prep_local(void) { return -ENOSYS; } > -- > 1.9.1 > > > -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 22EA96B0253 for ; Thu, 26 Jan 2017 04:18:38 -0500 (EST) Received: by mail-wm0-f72.google.com with SMTP id c206so43782303wme.3 for ; Thu, 26 Jan 2017 01:18:38 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id k189si25808656wme.5.2017.01.26.01.18.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 26 Jan 2017 01:18:36 -0800 (PST) Date: Thu, 26 Jan 2017 10:18:34 +0100 From: Michal Hocko Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined Message-ID: <20170126091833.GC6590@dhcp22.suse.cz> References: <1485356738-4831-1-git-send-email-ysxie@foxmail.com> <1485356738-4831-2-git-send-email-ysxie@foxmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485356738-4831-2-git-send-email-ysxie@foxmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: ysxie@foxmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote: > From: Yisheng Xie > > Define isolate_movable_page as a static inline function when > CONFIG_MIGRATION is not enable. It should return false > here which means failed to isolate movable pages. > > This patch do not have any functional change but prepare for > later patch. I think it would make more sense to make isolate_movable_page return int and have the same semantic as __isolate_lru_page. This would be a better preparatory patch for the later work. > Signed-off-by: Yisheng Xie > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Naoya Horiguchi > CC: Vlastimil Babka > --- > include/linux/migrate.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index ae8d475..631a8c8 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new, > free_page_t free, unsigned long private, enum migrate_mode mode, > int reason) > { return -ENOSYS; } > +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode) > + { return false; } > > static inline int migrate_prep(void) { return -ENOSYS; } > static inline int migrate_prep_local(void) { return -ENOSYS; } > -- > 1.9.1 > > > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org