From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40978 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbdAZJ0d (ORCPT ); Thu, 26 Jan 2017 04:26:33 -0500 Date: Thu, 26 Jan 2017 10:26:45 +0100 From: Greg KH To: Gabriel Krisman Bertazi Cc: stable@vger.kernel.org Subject: Re: [PATCH] mmc: sdhci: Ignore unexpected CARD_INT interrupts Message-ID: <20170126092645.GA32645@kroah.com> References: <20170126012335.28878-1-krisman@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126012335.28878-1-krisman@collabora.co.uk> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jan 25, 2017 at 11:23:35PM -0200, Gabriel Krisman Bertazi wrote: > Hi Greg, > > The following patch prevents an illegal command from getting sent to SD > cards, which in turn avoids a lock-up during boot. Can you please apply > to the 4.9 and 4.4 stable trees? > > The patch was generated against the 4.9 and there will be a trivial > context conflict when applying to the 4.4.y branch. If you prefer, I > can resend another version against that branch. > > Thanks! > > -- >8 -- > > commit 5b19196de18e1522630326c80a40a64181c78a1c upstream. I don't see this commit in Linus's tree, are you sure you got it correct? > One of our kernelCI boxes hanged at boot because a faulty eSDHC device > was triggering spurious CARD_INT interrupts for SD cards, causing CMD52 > reads, which are not allowed for SD devices. This adds a sanity check > to the interruption path, preventing that illegal command from getting > sent if the CARD_INT interruption should be disabled. > > This quirk allows that particular machine to resume boot despite the > faulty hardware, instead of getting hung dealing with thousands of > mishandled interrupts. > > Suggested-by: Adrian Hunter > Signed-off-by: Gabriel Krisman Bertazi > Acked-by: Adrian Hunter > Signed-off-by: Ulf Hansson > (cherry picked from commit 5b19196de18e1522630326c80a40a64181c78a1c) > --- > drivers/mmc/host/sdhci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Are you sure this is in Linus's tree? I can't find it anywhere. You did read Documentation/stable_kernel_rules.txt, right? thanks, greg k-h