From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbdAZBZD (ORCPT ); Wed, 25 Jan 2017 20:25:03 -0500 Received: from mail.kernel.org ([198.145.29.136]:56468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbdAZBZC (ORCPT ); Wed, 25 Jan 2017 20:25:02 -0500 Date: Thu, 26 Jan 2017 10:24:48 +0900 From: Masami Hiramatsu To: He Kuang Cc: , , , , , , , Subject: Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64 Message-Id: <20170126102448.a2e15edc57d36352fcfa9fa5@kernel.org> In-Reply-To: <20170124103015.1936-2-hekuang@huawei.com> References: <20170124103015.1936-1-hekuang@huawei.com> <20170124103015.1936-2-hekuang@huawei.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jan 2017 10:30:14 +0000 He Kuang wrote: > The register name of arm64 architecture is x0-x31 not r0-r31, this > patch changes this typo. > > Before this patch: > > # perf probe --definition 'sys_write count' > p:probe/sys_write _text+1502872 count=%r2:s64 > > # echo 'p:probe/sys_write _text+1502872 count=%r2:s64' > \ > /sys/kernel/debug/tracing/kprobe_events > Parse error at argument[0]. (-22) > > After this patch: > > # perf probe --definition 'sys_write count' > p:probe/sys_write _text+1502872 count=%x2:s64 > > # echo 'p:probe/sys_write _text+1502872 count=%x2:s64' > \ > /sys/kernel/debug/tracing/kprobe_events > # echo 1 >/sys/kernel/debug/tracing/events/probe/enable > # cat /sys/kernel/debug/tracing/trace > ... > sh-422 [000] d... 650.495930: sys_write: (SyS_write+0x0/0xc8) count=22 > sh-422 [000] d... 651.102389: sys_write: (SyS_write+0x0/0xc8) count=26 > sh-422 [000] d... 651.358653: sys_write: (SyS_write+0x0/0xc8) count=86 Ah, good catch! Acked-by: Masami Hiramatsu Thank you, > > Signed-off-by: He Kuang > --- > tools/perf/arch/arm64/include/dwarf-regs-table.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/arch/arm64/include/dwarf-regs-table.h b/tools/perf/arch/arm64/include/dwarf-regs-table.h > index 2675936..36e375f 100644 > --- a/tools/perf/arch/arm64/include/dwarf-regs-table.h > +++ b/tools/perf/arch/arm64/include/dwarf-regs-table.h > @@ -2,12 +2,12 @@ > /* This is included in perf/util/dwarf-regs.c */ > > static const char * const aarch64_regstr_tbl[] = { > - "%r0", "%r1", "%r2", "%r3", "%r4", > - "%r5", "%r6", "%r7", "%r8", "%r9", > - "%r10", "%r11", "%r12", "%r13", "%r14", > - "%r15", "%r16", "%r17", "%r18", "%r19", > - "%r20", "%r21", "%r22", "%r23", "%r24", > - "%r25", "%r26", "%r27", "%r28", "%r29", > + "%x0", "%x1", "%x2", "%x3", "%x4", > + "%x5", "%x6", "%x7", "%x8", "%x9", > + "%x10", "%x11", "%x12", "%x13", "%x14", > + "%x15", "%x16", "%x17", "%x18", "%x19", > + "%x20", "%x21", "%x22", "%x23", "%x24", > + "%x25", "%x26", "%x27", "%x28", "%x29", > "%lr", "%sp", > }; > #endif > -- > 1.8.5.2 > -- Masami Hiramatsu