From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbdAZMoT (ORCPT ); Thu, 26 Jan 2017 07:44:19 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35370 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbdAZMoS (ORCPT ); Thu, 26 Jan 2017 07:44:18 -0500 Date: Thu, 26 Jan 2017 15:44:16 +0300 From: Serge Semin To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree() Message-ID: <20170126124416.GC7785@mobilestation> References: <20170126090145.GA942@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126090145.GA942@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter wrote: > "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with > kfree() is a double free. In fact, we don't need to free it at all. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > index 25d47d09e1cb..f5f2c5a8d9b0 100644 > --- a/drivers/misc/eeprom/idt_89hpesx.c > +++ b/drivers/misc/eeprom/idt_89hpesx.c > @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) > pdev->ee_file->size = pdev->eesize; > ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file); > if (ret != 0) { > - kfree(pdev->ee_file); > dev_err(dev, "Failed to create EEPROM sysfs-node"); > return ret; > } > @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) > > /* Remove EEPROM sysfs file */ > sysfs_remove_bin_file(&dev->kobj, pdev->ee_file); > - > - /* Free memory allocated for bin_attribute structure */ > - kfree(pdev->ee_file); > } > > /* Just got the same patch a day earlier, but still thanks for the pointing the issue out. Regards, -Sergey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Semin Date: Thu, 26 Jan 2017 12:44:16 +0000 Subject: Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree() Message-Id: <20170126124416.GC7785@mobilestation> List-Id: References: <20170126090145.GA942@mwanda> In-Reply-To: <20170126090145.GA942@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter wrote: > "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with > kfree() is a double free. In fact, we don't need to free it at all. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c > index 25d47d09e1cb..f5f2c5a8d9b0 100644 > --- a/drivers/misc/eeprom/idt_89hpesx.c > +++ b/drivers/misc/eeprom/idt_89hpesx.c > @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) > pdev->ee_file->size = pdev->eesize; > ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file); > if (ret != 0) { > - kfree(pdev->ee_file); > dev_err(dev, "Failed to create EEPROM sysfs-node"); > return ret; > } > @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) > > /* Remove EEPROM sysfs file */ > sysfs_remove_bin_file(&dev->kobj, pdev->ee_file); > - > - /* Free memory allocated for bin_attribute structure */ > - kfree(pdev->ee_file); > } > > /* Just got the same patch a day earlier, but still thanks for the pointing the issue out. Regards, -Sergey