All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Michal Marek <mmarek@suse.cz>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	"Hsu, Ray" <ray.hsu@intel.com>,
	Sridhara.Venkatanara@dell.com, "Chen,
	Angus" <angus.chen@intel.com>, Jeffrey Cheung <jcheung@suse.com>
Subject: Re: Broken DPMS with DisplayPort on CHV (also BYT?)
Date: Thu, 26 Jan 2017 15:58:55 +0200	[thread overview]
Message-ID: <20170126135855.GE31595@intel.com> (raw)
In-Reply-To: <s5hr33rmh6k.wl-tiwai@suse.de>

On Wed, Jan 25, 2017 at 01:56:35PM +0100, Takashi Iwai wrote:
> Hi,
> 
> we've got a bug report about the blank monitor on Cherry Trail
> machines.  And, Intel team (Cc'ed) spotted out that this seems
> triggered by DPMS transition.  A patch like below actually fixes the
> problem.
> 
> Of course it doesn't look like a right "fix".  Do you guys have any
> hint for further debugging?

Is it some kind of new fangled MST capable monitor? I've noticed that
those tend to be super easy to mess up.

> 
> Some more (not alt-) facts:
> 
> - The machine we've tested is a Cherry Trail based box with two
>   DisplayPorts.  Intel team mentioned that there are other machines
>   suffering from the same problem.

Is it really somehow tied to the machine? I would imagine it should
behave exactly the same way no matter what machine you have.

> 
> - With some monitors, the screen remains blank during boot and on X.
>   This can be cured after "xset dpms force off" and resume, or
>   reconfiguring via xrandr.
> 
> - The issue seems specific to DP connections.  When two (identical)
>   monitors are connected, only one monitor goes blank.

Hmm. Have you tried 9f2bdb006a7e ("drm/i915: Prevent PPS stealing
from a normal DP port on VLV/CHV") ?

> 
> - The issue happens only with some monitor models (Dell E-series).
>   Other Dell monitors (e.g. U-series) or other vendors seem working as
>   far as we've tested.
> 
> - Intel team mentioned that a similar issue was seen on a Baytrail
>   machine.
> 
> - The register value seems passed correctly.  The read back after the
>   register write showed the expected value.
>   Also, spinning more times in DPMS_ON loop didn't help, too.
> 
> - The issue is reproduced with the recent kernels (at least 4.9.x)
> 
> 
> Any comments / suggestions appreciated.
> 
> thanks,
> 
> Takashi
> 
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2205,8 +2205,12 @@ void intel_dp_sink_dpms(struct intel_dp
>  		return;
>  
>  	if (mode != DRM_MODE_DPMS_ON) {
> +#if 0
>  		ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER,
>  					 DP_SET_POWER_D3);
> +#else
> +		ret = 1;
> +#endif
>  	} else {
>  		/*
>  		 * When turning on, we need to retry for 1ms to give the sink
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-01-26 13:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 12:56 Broken DPMS with DisplayPort on CHV (also BYT?) Takashi Iwai
2017-01-26 13:58 ` Ville Syrjälä [this message]
2017-01-26 14:19   ` Takashi Iwai
2017-01-27  7:13     ` Sridhara.Venkatanara
2017-01-27 10:29     ` Takashi Iwai
2017-01-31  2:34       ` Jeffrey Cheung
2017-01-31  5:49         ` Takashi Iwai
2017-01-31  6:09           ` Jeffrey Cheung
2017-01-31  7:35             ` Sridhara.Venkatanara
2017-01-31  9:02               ` lRE: " Jeffrey Cheung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126135855.GE31595@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=Sridhara.Venkatanara@dell.com \
    --cc=angus.chen@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jcheung@suse.com \
    --cc=mmarek@suse.cz \
    --cc=ray.hsu@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.