From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933895AbdA0RTb (ORCPT ); Fri, 27 Jan 2017 12:19:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933531AbdA0RSe (ORCPT ); Fri, 27 Jan 2017 12:18:34 -0500 Date: Fri, 27 Jan 2017 18:18:27 +0100 From: Benjamin Tissoires To: Christophe JAILLET Cc: dmitry.torokhov@gmail.com, aduggan@synaptics.com, nick@shmanahar.org, yamada.masahiro@socionext.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4 - Fix reversed tests Message-ID: <20170127171827.GE13244@mail.corp.redhat.com> References: <20170127121115.19427-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170127121115.19427-1-christophe.jaillet@wanadoo.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 27 Jan 2017 17:18:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jan 27 2017 or thereabouts, Christophe JAILLET wrote: > These tests looks reversed. > A warning should be displayed if an error is returned, not on success. > > Signed-off-by: Christophe JAILLET > --- Good catch! Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/input/rmi4/rmi_driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c > index 11447ab1055c..bf5c36e229ba 100644 > --- a/drivers/input/rmi4/rmi_driver.c > +++ b/drivers/input/rmi4/rmi_driver.c > @@ -901,7 +901,7 @@ void rmi_enable_irq(struct rmi_device *rmi_dev, bool clear_wake) > data->enabled = true; > if (clear_wake && device_may_wakeup(rmi_dev->xport->dev)) { > retval = disable_irq_wake(irq); > - if (!retval) > + if (retval) > dev_warn(&rmi_dev->dev, > "Failed to disable irq for wake: %d\n", > retval); > @@ -936,7 +936,7 @@ void rmi_disable_irq(struct rmi_device *rmi_dev, bool enable_wake) > disable_irq(irq); > if (enable_wake && device_may_wakeup(rmi_dev->xport->dev)) { > retval = enable_irq_wake(irq); > - if (!retval) > + if (retval) > dev_warn(&rmi_dev->dev, > "Failed to enable irq for wake: %d\n", > retval); > -- > 2.9.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Date: Fri, 27 Jan 2017 17:18:27 +0000 Subject: Re: [PATCH] Input: synaptics-rmi4 - Fix reversed tests Message-Id: <20170127171827.GE13244@mail.corp.redhat.com> List-Id: References: <20170127121115.19427-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170127121115.19427-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: dmitry.torokhov@gmail.com, aduggan@synaptics.com, nick@shmanahar.org, yamada.masahiro@socionext.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Jan 27 2017 or thereabouts, Christophe JAILLET wrote: > These tests looks reversed. > A warning should be displayed if an error is returned, not on success. > > Signed-off-by: Christophe JAILLET > --- Good catch! Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/input/rmi4/rmi_driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c > index 11447ab1055c..bf5c36e229ba 100644 > --- a/drivers/input/rmi4/rmi_driver.c > +++ b/drivers/input/rmi4/rmi_driver.c > @@ -901,7 +901,7 @@ void rmi_enable_irq(struct rmi_device *rmi_dev, bool clear_wake) > data->enabled = true; > if (clear_wake && device_may_wakeup(rmi_dev->xport->dev)) { > retval = disable_irq_wake(irq); > - if (!retval) > + if (retval) > dev_warn(&rmi_dev->dev, > "Failed to disable irq for wake: %d\n", > retval); > @@ -936,7 +936,7 @@ void rmi_disable_irq(struct rmi_device *rmi_dev, bool enable_wake) > disable_irq(irq); > if (enable_wake && device_may_wakeup(rmi_dev->xport->dev)) { > retval = enable_irq_wake(irq); > - if (!retval) > + if (retval) > dev_warn(&rmi_dev->dev, > "Failed to enable irq for wake: %d\n", > retval); > -- > 2.9.3 >