From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver
Date: Fri, 27 Jan 2017 16:58:48 -0500 [thread overview]
Message-ID: <20170127215848.GG25829@oracle.com> (raw)
In-Reply-To: <CAF=yD-+GGAdvgXoZeMshyQXXh_3m9kjDGNFf9FQ43rxJgk__vw@mail.gmail.com>
On (01/27/17 15:51), Willem de Bruijn wrote:
:
> - limit capable() check to drivers with with .validate callback
(aka second option below)
:
> - let privileged applications shoot themselves in the foot (change nothing).
> The second will break variable length header protocols unless
> you exhaustively search for all variable length protocols and add
> validate callbacks first.
other than ax25, are there variable length header protocols out there
without ->validate, and which need the CAP_RAW_SYSIO branch?
I realize that, to an extent, even ethernet is a protocol whose
header is > 14 with vlan, but from the google search, seems like it
was mostly ax25 that really triggered a large part of the check.
If we think that there are a large number of these (that dont have a
->validate, to fix up things as desired) I'd just go for the "change
nothing in pf_packet" option.
As I found out many drivers like ixgbe and sunvnet have defensive checks
in the Tx path anyway, and xen_netfront can also join that group with
a few simple checks.
next prev parent reply other threads:[~2017-01-27 22:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 16:11 [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver Sowmini Varadhan
2017-01-25 17:45 ` David Miller
2017-01-26 20:21 ` Willem de Bruijn
2017-01-26 21:37 ` Sowmini Varadhan
2017-01-27 0:08 ` Willem de Bruijn
2017-01-27 2:08 ` Sowmini Varadhan
2017-01-27 14:37 ` Willem de Bruijn
2017-01-27 15:11 ` Sowmini Varadhan
2017-01-27 15:28 ` Willem de Bruijn
2017-01-27 17:03 ` Sowmini Varadhan
2017-01-27 19:29 ` Willem de Bruijn
2017-01-27 20:06 ` Sowmini Varadhan
2017-01-27 20:51 ` Willem de Bruijn
2017-01-27 21:58 ` Sowmini Varadhan [this message]
2017-01-28 0:19 ` Willem de Bruijn
2017-01-30 16:26 ` Sowmini Varadhan
2017-01-30 16:41 ` David Miller
2017-02-07 20:51 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127215848.GG25829@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.