From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [RFC XEN PATCH 14/16] tools/libxl: add support to map files on pmem devices to guests Date: Fri, 27 Jan 2017 17:10:51 -0500 Message-ID: <20170127221051.GJ18581@localhost.localdomain> References: <20161010003235.4213-1-haozhong.zhang@intel.com> <20161010003235.4213-15-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161010003235.4213-15-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Xiao Guangrong , Wei Liu , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBPY3QgMTAsIDIwMTYgYXQgMDg6MzI6MzNBTSArMDgwMCwgSGFvemhvbmcgWmhhbmcg d3JvdGU6Cj4gV2UgY2FuIG1hcCBob3N0IHBtZW0gZGV2aWNlcyBvciBmaWxlcyBvbiBwbWVtIGRl dmljZXMgdG8gZ3Vlc3RzLiBUaGlzCj4gcGF0Y2ggYWRkcyBzdXBwb3J0IHRvIG1hcCBmaWxlcyBv biBwbWVtIGRldmljZXMuIFRoZSBpbXBsZW1lbnRhdGlvbgo+IHJlbGllcyBvbiB0aGUgTGludXgg cG1lbSBkcml2ZXIgYW5kIGtlcm5lbCBBUElzLCBzbyBpdCBjdXJyZW50bHkKCk1heSB3YW50IHRv IG1lbnRpb24gd2hpY2ggQ09ORklHXyBvcHRpb25zIGFyZSBuZWVkZWQuCj4gZnVuY3Rpb25zIG9u bHkgd2hlbiBsaWJ4bCBpcyBjb21waWxlZCBmb3IgTGludXguCj4gCj4gU2lnbmVkLW9mZi1ieTog SGFvemhvbmcgWmhhbmcgPGhhb3pob25nLnpoYW5nQGludGVsLmNvbT4KPiAtLS0KPiBDYzogSWFu IEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IFdlaSBMaXUgPHdlaS5s aXUyQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHRvb2xzL2xpYnhsL2xpYnhsX252ZGltbS5jIHwgNzMg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAxIGZpbGUg Y2hhbmdlZCwgNzIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQg YS90b29scy9saWJ4bC9saWJ4bF9udmRpbW0uYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX252ZGltbS5j Cj4gaW5kZXggN2JjYmFhZi4uYjNiYTE5YSAxMDA2NDQKPiAtLS0gYS90b29scy9saWJ4bC9saWJ4 bF9udmRpbW0uYwo+ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX252ZGltbS5jCj4gQEAgLTI1LDYg KzI1LDkgQEAKPiAgI2luY2x1ZGUgPHVuaXN0ZC5oPgo+ICAjaW5jbHVkZSA8ZXJybm8uaD4KPiAg I2luY2x1ZGUgPHN0ZGludC5oPgo+ICsjaW5jbHVkZSA8c3lzL2lvY3RsLmg+Cj4gKyNpbmNsdWRl IDxsaW51eC9mcy5oPgo+ICsjaW5jbHVkZSA8bGludXgvZmllbWFwLmg+Cj4gIAo+ICAjaW5jbHVk ZSAibGlieGxfaW50ZXJuYWwuaCIKPiAgI2luY2x1ZGUgImxpYnhsX2FyY2guaCIKPiBAQCAtOTcs MTAgKzEwMCw3OCBAQCBzdGF0aWMgaW50IGFkZF9wYWdlcyhsaWJ4bF9fZ2MgKmdjLCB1aW50MzJf dCBkb21pZCwKPiAgICAgIHJldHVybiByZXQ7Cj4gIH0KPiAgCj4gK3N0YXRpYyB1aW50NjRfdAo+ ICtnZXRfZmlsZV9leHRlbnRzKGxpYnhsX19nYyAqZ2MsIGludCBmZCwgdW5zaWduZWQgbG9uZyBs ZW5ndGgsCj4gKyAgICAgICAgICAgICAgICAgc3RydWN0IGZpZW1hcF9leHRlbnQgKipleHRlbnRz X3IpCj4gK3sKPiArICAgIHN0cnVjdCBmaWVtYXAgKmZpZW1hcDsKPiArICAgIHVpbnQ2NF90IG5y X2V4dGVudHMgPSAwLCBleHRlbnRzX3NpemU7Cj4gKwo+ICsgICAgZmllbWFwID0gbGlieGxfX3ph bGxvYyhnYywgc2l6ZW9mKCpmaWVtYXApKTsKPiArICAgIGlmICggIWZpZW1hcCApCj4gKyAgICAg ICAgZ290byBvdXQ7Cj4gKwo+ICsgICAgZmllbWFwLT5mbV9sZW5ndGggPSBsZW5ndGg7Cj4gKyAg ICBpZiAoIGlvY3RsKGZkLCBGU19JT0NfRklFTUFQLCBmaWVtYXApIDwgMCApCj4gKyAgICAgICAg Z290byBvdXQ7Cj4gKwo+ICsgICAgbnJfZXh0ZW50cyA9IGZpZW1hcC0+Zm1fbWFwcGVkX2V4dGVu dHM7Cj4gKyAgICBleHRlbnRzX3NpemUgPSBzaXplb2Yoc3RydWN0IGZpZW1hcF9leHRlbnQpICog bnJfZXh0ZW50czsKPiArICAgIGZpZW1hcCA9IGxpYnhsX19yZWFsbG9jKGdjLCBmaWVtYXAsIHNp emVvZigqZmllbWFwKSArIGV4dGVudHNfc2l6ZSk7Cj4gKyAgICBpZiAoICFmaWVtYXAgKQo+ICsg ICAgICAgIGdvdG8gb3V0Owo+ICsKPiArICAgIG1lbXNldChmaWVtYXAtPmZtX2V4dGVudHMsIDAs IGV4dGVudHNfc2l6ZSk7Cj4gKyAgICBmaWVtYXAtPmZtX2V4dGVudF9jb3VudCA9IG5yX2V4dGVu dHM7Cj4gKyAgICBmaWVtYXAtPmZtX21hcHBlZF9leHRlbnRzID0gMDsKPiArCj4gKyAgICBpZiAo IGlvY3RsKGZkLCBGU19JT0NfRklFTUFQLCBmaWVtYXApIDwgMCApCj4gKyAgICAgICAgZ290byBv dXQ7Cj4gKwo+ICsgICAgKmV4dGVudHNfciA9IGZpZW1hcC0+Zm1fZXh0ZW50czsKPiArCj4gKyBv dXQ6Cj4gKyAgICByZXR1cm4gbnJfZXh0ZW50czsKPiArfQo+ICsKPiAgc3RhdGljIGludCBhZGRf ZmlsZShsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwgaW50IGZkLAo+ICAgICAgICAgICAg ICAgICAgICAgIHhlbl9wZm5fdCBtZm4sIHhlbl9wZm5fdCBncGZuLCB1bnNpZ25lZCBsb25nIG5y X21mbnMpCj4gIHsKPiAtICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgc3RydWN0IGZpZW1hcF9l eHRlbnQgKmV4dGVudHM7Cj4gKyAgICB1aW50NjRfdCBucl9leHRlbnRzLCBpOwo+ICsgICAgaW50 IHJldCA9IDA7Cj4gKwo+ICsgICAgbnJfZXh0ZW50cyA9IGdldF9maWxlX2V4dGVudHMoZ2MsIGZk LCBucl9tZm5zIDw8IFhDX1BBR0VfU0hJRlQsICZleHRlbnRzKTsKPiArICAgIGlmICggIW5yX2V4 dGVudHMgKQo+ICsgICAgICAgIHJldHVybiAtRUlPOwo+ICsKPiArICAgIGZvciAoIGkgPSAwOyBp IDwgbnJfZXh0ZW50czsgaSsrICkKPiArICAgIHsKPiArICAgICAgICB1aW50NjRfdCBwX29mZnNl dCA9IGV4dGVudHNbaV0uZmVfcGh5c2ljYWw7Cj4gKyAgICAgICAgdWludDY0X3QgbF9vZmZzZXQg PSBleHRlbnRzW2ldLmZlX2xvZ2ljYWw7Cj4gKyAgICAgICAgdWludDY0X3QgbGVuZ3RoID0gZXh0 ZW50c1tpXS5mZV9sZW5ndGg7Cj4gKwo+ICsgICAgICAgIGlmICggZXh0ZW50c1tpXS5mZV9mbGFn cyAmIH5GSUVNQVBfRVhURU5UX0xBU1QgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgcmV0 ID0gLUVJTlZBTDsKPiArICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgfQo+ICsKPiArICAg ICAgICBpZiAoIChwX29mZnNldCB8IGxfb2Zmc2V0IHwgbGVuZ3RoKSAmIH5YQ19QQUdFX01BU0sg KQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgcmV0ID0gLUVJTlZBTDsKPiArICAgICAgICAg ICAgYnJlYWs7Cj4gKyAgICAgICAgfQo+ICsKPiArICAgICAgICByZXQgPSBhZGRfcGFnZXMoZ2Ms IGRvbWlkLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICBtZm4gKyAocF9vZmZzZXQgPj4gWENf UEFHRV9TSElGVCksCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIGdwZm4gKyAobF9vZmZzZXQg Pj4gWENfUEFHRV9TSElGVCksCj4gKyAgICAgICAgICAgICAgICAgICAgICAgIGxlbmd0aCA+PiBY Q19QQUdFX1NISUZUKTsKPiArICAgICAgICBpZiAoIHJldCApCj4gKyAgICAgICAgICAgIGJyZWFr Owo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIGludCBsaWJ4bF9u dmRpbW1fYWRkX2RldmljZShsaWJ4bF9fZ2MgKmdjLAo+IC0tIAo+IDIuMTAuMQo+IAo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gWGVuLWRldmVs IG1haWxpbmcgbGlzdAo+IFhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCj4gaHR0cHM6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==