From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 09/11] libbnxtre: Add support for atomic operations Date: Sun, 29 Jan 2017 16:46:02 -0700 Message-ID: <20170129234602.GH24051@obsidianresearch.com> References: <1485641622-30015-1-git-send-email-devesh.sharma@broadcom.com> <1485641622-30015-10-git-send-email-devesh.sharma@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1485641622-30015-10-git-send-email-devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Devesh Sharma Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sriharsha Basavapatna , Somnath Kotur , Selvin Xavier List-Id: linux-rdma@vger.kernel.org On Sat, Jan 28, 2017 at 05:13:40PM -0500, Devesh Sharma wrote: > +#define upper_32_bits(n) ((__u32)(((n) >> 16) >> 16)) This can be >> 16 > +#define lower_32_bits(n) ((__u32)((n) & 0xFFFFFFFFUL)) Do not define macros as functions. Use static inline instead. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html