From: David Miller <davem@davemloft.net>
To: kafai@fb.com
Cc: netdev@vger.kernel.org, bblanco@plumgrid.com,
saeedm@mellanox.com, tariqt@mellanox.com, kernel-team@fb.com
Subject: Re: [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G'
Date: Mon, 30 Jan 2017 09:56:52 -0500 (EST) [thread overview]
Message-ID: <20170130.095652.206333902555980419.davem@davemloft.net> (raw)
In-Reply-To: <1485589251-3896393-1-git-send-email-kafai@fb.com>
From: Martin KaFai Lau <kafai@fb.com>
Date: Fri, 27 Jan 2017 23:40:51 -0800
> If the rx-queues ever get re-initialized (e.g. by changing the
> number of rx-queues with ethtool -L), the existing xdp_prog becomes
> inactive.
>
> The bug is that the xdp_prog ptr has not been carried over from
> the old rx-queues to the new rx-queues
>
> Fixes: 47a38e155037 ("net/mlx4_en: add support for fast rx drop bpf program")
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Mellanox folks, please review.
next prev parent reply other threads:[~2017-01-30 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 7:40 [PATCH net] mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G' Martin KaFai Lau
2017-01-30 14:56 ` David Miller [this message]
2017-01-30 17:18 ` Tariq Toukan
2017-01-31 18:11 ` David Miller
2017-01-31 21:32 ` Martin KaFai Lau
2017-02-01 5:54 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130.095652.206333902555980419.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bblanco@plumgrid.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.