All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] git-crypt: new package
Date: Mon, 30 Jan 2017 07:28:32 +0200	[thread overview]
Message-ID: <20170130052832.bo2h4xebwfbbe4zo@tarshish> (raw)
In-Reply-To: <20170130002853.76103-1-francesconegri@gmail.com>

Hi Francesco,

On Mon, Jan 30, 2017 at 01:28:53AM +0100, Francesco Negri wrote:
> Signed-off-by: Francesco Negri <francesconegri@gmail.com>
> ---
>  package/Config.in                |  1 +
>  package/git-crypt/Config.in      |  9 +++++++++
>  package/git-crypt/git-crypt.hash |  2 ++
>  package/git-crypt/git-crypt.mk   | 21 +++++++++++++++++++++
>  4 files changed, 33 insertions(+)
>  create mode 100644 package/git-crypt/Config.in
>  create mode 100644 package/git-crypt/git-crypt.hash
>  create mode 100644 package/git-crypt/git-crypt.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 6a3a1a7c7..067ff3cc9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -138,6 +138,7 @@ menu "Development tools"
>  	source "package/gawk/Config.in"
>  	source "package/gettext/Config.in"
>  	source "package/git/Config.in"
> +	source "package/git-crypt/Config.in"
>  	source "package/gperf/Config.in"
>  	source "package/grep/Config.in"
>  	source "package/jq/Config.in"
> diff --git a/package/git-crypt/Config.in b/package/git-crypt/Config.in
> new file mode 100644
> index 000000000..15a12b5c6
> --- /dev/null
> +++ b/package/git-crypt/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_GIT_CRYPT
> +	bool "git-crypt"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	select BR2_PACKAGE_GIT

You should also propagate BR2_PACKAGE_GIT dependency here (BR2_USE_MMU).

> +	help
> +	  git-crypt enables transparent encryption and decryption of files in a
> +	  git repository.
> +
> +	  https://github.com/AGWA/git-crypt

https://www.agwa.name/projects/git-crypt/ looks more informative.

A dependencies comment is missing. See section 17.2.4 in the manual[1].

> diff --git a/package/git-crypt/git-crypt.hash b/package/git-crypt/git-crypt.hash
> new file mode 100644
> index 000000000..fe18498cc
> --- /dev/null
> +++ b/package/git-crypt/git-crypt.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 5150144a528bc74eeb47a2884cf2fefe978a1d1dc0223bbfcac395fa6a73a410 git-crypt-0.5.0.tar.gz

Upstream tarball (see below) has upstream provided hash[2].

> diff --git a/package/git-crypt/git-crypt.mk b/package/git-crypt/git-crypt.mk
> new file mode 100644
> index 000000000..9f7df223d
> --- /dev/null
> +++ b/package/git-crypt/git-crypt.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# git-crypt
> +#
> +################################################################################
> +
> +GIT_CRYPT_VERSION = 0.5.0
> +GIT_CRYPT_SITE = $(call github,agwa,git-crypt,$(GIT_CRYPT_VERSION))

Any reason not to use upstream tarball?

https://www.agwa.name/projects/git-crypt/downloads/git-crypt-0.5.0.tar.gz

> +GIT_CRYPT_DEPENDENCIES = git openssl

A 'select BR2_PACKAGE_OPENSSL' in Config.in is missing.

> +GIT_CRYPT_LICENSE = GPLv3
> +GIT_CRYPT_LICENSE_FILES = COPYING
> +
> +define GIT_CRYPT_BUILD_CMDS
> +	$(MAKE) CXX="$(TARGET_CXX)" -C $(@D) all
> +endef
> +
> +define GIT_CRYPT_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/git-crypt $(TARGET_DIR)/usr/bin/git-crypt
> +endef
> +
> +$(eval $(generic-package))

baruch

[1] http://nightly.buildroot.org/manual.html

[2] https://lists.cloudmutt.com/pipermail/git-crypt-announce/2015-May/000003.html

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2017-01-30  5:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30  0:28 [Buildroot] [PATCH 1/1] git-crypt: new package Francesco Negri
2017-01-30  5:28 ` Baruch Siach [this message]
2017-01-30  9:38   ` Francesco Negri
2017-01-30 10:54   ` Thomas Petazzoni
2017-01-30 10:58 ` [Buildroot] [PATCH v2 " Francesco Negri
2017-01-30 11:02   ` Baruch Siach
2017-01-30 11:07     ` Francesco Negri
2017-01-30 12:08       ` Francesco Negri
2017-01-30 12:28         ` Baruch Siach
2017-01-30 13:27   ` [Buildroot] [PATCH v3 " Francesco Negri
2017-01-30 13:38     ` Baruch Siach
2017-01-30 13:55     ` [Buildroot] [PATCH v4 " Francesco Negri
2017-01-30 14:36       ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2017-01-30  0:13 [Buildroot] [PATCH " Francesco Negri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170130052832.bo2h4xebwfbbe4zo@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.