From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbdA3GkV (ORCPT ); Mon, 30 Jan 2017 01:40:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43944 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbdA3GkP (ORCPT ); Mon, 30 Jan 2017 01:40:15 -0500 Date: Mon, 30 Jan 2017 07:40:19 +0100 From: Greg Kroah-Hartman To: James Simmons Cc: Joe Perches , devel@driverdev.osuosl.org, James Simmons , Andreas Dilger , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List Subject: Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure Message-ID: <20170130064018.GA4108@kroah.com> References: <1485045632-5886-1-git-send-email-jsimmons@infradead.org> <1485205276.12563.30.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 11:56:38PM +0000, James Simmons wrote: > > > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > > The upstream kernel requires proper structures so > > > convert nearly all the LNet wire protocols typedefs in > > > the LNet core. > > > > Thanks. > > > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too > > I liked to keep that one. Sorry, but no. > The point of WIRE_ATTR isn't to be some abstraction but to label that > struct as something that goes over the wire. This lets people know > that it would break something if you change that structure. Looks like > I need to send a patch that adds a comment explaning the meaning of > WIRE_ATTR. No, please remove it, it's not anything that any other kernel subsystem uses. It's easy to know if you will break something, anything that crosses the user/kernel boundry falls into that category, so if it is in a uapi .h file, that's going to be the case. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Mon, 30 Jan 2017 07:40:19 +0100 Subject: [lustre-devel] [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure In-Reply-To: References: <1485045632-5886-1-git-send-email-jsimmons@infradead.org> <1485205276.12563.30.camel@perches.com> Message-ID: <20170130064018.GA4108@kroah.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Simmons Cc: Joe Perches , devel@driverdev.osuosl.org, James Simmons , Andreas Dilger , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List On Sun, Jan 29, 2017 at 11:56:38PM +0000, James Simmons wrote: > > > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > > The upstream kernel requires proper structures so > > > convert nearly all the LNet wire protocols typedefs in > > > the LNet core. > > > > Thanks. > > > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too > > I liked to keep that one. Sorry, but no. > The point of WIRE_ATTR isn't to be some abstraction but to label that > struct as something that goes over the wire. This lets people know > that it would break something if you change that structure. Looks like > I need to send a patch that adds a comment explaning the meaning of > WIRE_ATTR. No, please remove it, it's not anything that any other kernel subsystem uses. It's easy to know if you will break something, anything that crosses the user/kernel boundry falls into that category, so if it is in a uapi .h file, that's going to be the case. thanks, greg k-h