From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbdA3I4H (ORCPT ); Mon, 30 Jan 2017 03:56:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbdA3Izv (ORCPT ); Mon, 30 Jan 2017 03:55:51 -0500 Date: Mon, 30 Jan 2017 09:55:47 +0100 From: Jiri Olsa To: Taeung Song Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan Subject: Re: [PATCH 2/2] perf evsel: Check for NULL before perf_evsel__is_bpf_output() Message-ID: <20170130085547.GB22029@krava> References: <1485753819-12857-1-git-send-email-treeze.taeung@gmail.com> <1485753819-12857-2-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485753819-12857-2-git-send-email-treeze.taeung@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 30 Jan 2017 08:55:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote: > If 'evsel' is NULL, in perf_evsel__is_bpf_output() > NULL pointer error can happen so check it. > > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song > --- > tools/perf/util/evsel.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 04e536a..b77da72 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -242,8 +242,10 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx) > { > struct perf_evsel *evsel = zalloc(perf_evsel__object.size); > > - if (evsel != NULL) > - perf_evsel__init(evsel, attr, idx); > + if (!evsel) > + return NULL; > + > + perf_evsel__init(evsel, attr, idx); Acked-by: Jiri Olsa thanks, jirka