From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753064AbdA3MKs (ORCPT ); Mon, 30 Jan 2017 07:10:48 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37720 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbdA3MKa (ORCPT ); Mon, 30 Jan 2017 07:10:30 -0500 Date: Mon, 30 Jan 2017 12:09:19 +0000 From: Russell King - ARM Linux To: Afzal Mohammed Cc: Vladimir Murzin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: nommu: display vectors base Message-ID: <20170130120919.GP27312@n2100.armlinux.org.uk> References: <20170118203525.6246-1-afzal.mohd.ma@gmail.com> <20170118203837.6536-1-afzal.mohd.ma@gmail.com> <20170118221315.GP27312@n2100.armlinux.org.uk> <20170119131632.GA3862@afzalpc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170119131632.GA3862@afzalpc> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2017 at 06:46:32PM +0530, Afzal Mohammed wrote: > Hi, > > On Wed, Jan 18, 2017 at 10:13:15PM +0000, Russell King - ARM Linux wrote: > > On Thu, Jan 19, 2017 at 02:08:37AM +0530, afzal mohammed wrote: > > > > + MLK_ROUNDUP(vectors_base, vectors_base + PAGE_SIZE), > > > > I think MLK() will do here - no need to use the rounding-up version > > as PAGE_SIZE is a multiple of 1k. > > Yes, i will replace it. > > Earlier, used MLK(), got some build error, now checking again, no > build error, i should have messed up something at that time. Sorry for the delayed response. With that change, you can get rid of this preprocessor conditional. Arrange to have VECTORS_BASE defined to vectors_base in the nommu part of asm/memory.h. You'll also need to move the extern of that there too. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Mon, 30 Jan 2017 12:09:19 +0000 Subject: [PATCH 3/4] ARM: nommu: display vectors base In-Reply-To: <20170119131632.GA3862@afzalpc> References: <20170118203525.6246-1-afzal.mohd.ma@gmail.com> <20170118203837.6536-1-afzal.mohd.ma@gmail.com> <20170118221315.GP27312@n2100.armlinux.org.uk> <20170119131632.GA3862@afzalpc> Message-ID: <20170130120919.GP27312@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 19, 2017 at 06:46:32PM +0530, Afzal Mohammed wrote: > Hi, > > On Wed, Jan 18, 2017 at 10:13:15PM +0000, Russell King - ARM Linux wrote: > > On Thu, Jan 19, 2017 at 02:08:37AM +0530, afzal mohammed wrote: > > > > + MLK_ROUNDUP(vectors_base, vectors_base + PAGE_SIZE), > > > > I think MLK() will do here - no need to use the rounding-up version > > as PAGE_SIZE is a multiple of 1k. > > Yes, i will replace it. > > Earlier, used MLK(), got some build error, now checking again, no > build error, i should have messed up something at that time. Sorry for the delayed response. With that change, you can get rid of this preprocessor conditional. Arrange to have VECTORS_BASE defined to vectors_base in the nommu part of asm/memory.h. You'll also need to move the extern of that there too. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.