On Mon, Jan 30, 2017 at 11:00:28AM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 30, 2017 at 5:55 AM, Shailendra Verma > wrote: > > of_match_device could return NULL, and so can cause a NULL > > pointer dereference later. > Can it? The driver uses DT exclusively. > There is no legacy platform code creating "mxs-spi" platform devices. Yeah, the changelogs on these aren't very good - there's no present risk, though future changes could potentially cause an issue so it's not unreasonable to do it defensively.