From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbdA3Qq6 (ORCPT ); Mon, 30 Jan 2017 11:46:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54598 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbdA3QoU (ORCPT ); Mon, 30 Jan 2017 11:44:20 -0500 Date: Mon, 30 Jan 2017 17:44:23 +0100 From: Greg Kroah-Hartman To: Maksymilian Piechota Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement Message-ID: <20170130164423.GA12941@kroah.com> References: <20170130163142.GA9425@maks-debian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170130163142.GA9425@maks-debian.localdomain> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 11:31:42AM -0500, Maksymilian Piechota wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Statements should start on a tabstop > > Signed-off-by: Maksymilian Piechota > --- > drivers/staging/wlan-ng/prism2mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > index 16fb2d3..2d67125 100644 > --- a/drivers/staging/wlan-ng/prism2mgmt.c > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > @@ -1308,7 +1308,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > hw->sniffhdr = 0; > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > } else > - if ((msg->wlanheader.status == > + if ((msg->wlanheader.status == > P80211ENUM_msgitem_status_data_ok) > && (msg->wlanheader.data == P80211ENUM_truth_true)) { > hw->sniffhdr = 1; Hm, this all doesn't look correct now, does it? Please fix up the whole if statement here. thanks, greg k-h