[kvm:queue 8/8] drivers/ptp/ptp_kvm.c:88:35: error: incompatible type for argument 1 of 'timespec_to_ktime'

[kvm:queue 8/8] drivers/ptp/ptp_kvm.c:88:35: error: incompatible type for argument 1 of 'timespec_to_ktime'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
head:   6cd1eaf959a3c27612d13173f0530f4ab6a2ad11
commit: 6cd1eaf959a3c27612d13173f0530f4ab6a2ad11 [8/8] PTP: add kvm PTP driver
config: i386-randconfig-h0-01280042 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 6cd1eaf959a3c27612d13173f0530f4ab6a2ad11
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/ptp/ptp_kvm.c: In function 'ptp_kvm_get_time_fn':
>> drivers/ptp/ptp_kvm.c:88:35: error: incompatible type for argument 1 of 'timespec_to_ktime'
     *device_time = timespec_to_ktime(tspec);
                                      ^~~~~
   In file included from include/linux/rcupdate.h:47:0,
                    from include/linux/idr.h:18,
                    from include/linux/kernfs.h:14,
                    from include/linux/sysfs.h:15,
                    from include/linux/kobject.h:21,
                    from include/linux/device.h:17,
                    from drivers/ptp/ptp_kvm.c:17:
   include/linux/ktime.h:70:23: note: expected 'struct timespec' but argument is of type 'struct timespec64'
    static inline ktime_t timespec_to_ktime(struct timespec ts)
                          ^~~~~~~~~~~~~~~~~

vim +/timespec_to_ktime +88 drivers/ptp/ptp_kvm.c

    82	
    83		preempt_enable_notrace();
    84	
    85		system_counter->cycles = ret;
    86		system_counter->cs = &kvm_clock;
    87	
  > 88		*device_time = timespec_to_ktime(tspec);
    89	
    90		spin_unlock(&kvm_ptp_lock);
    91	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23055 bytes --]

Re: [kvm:queue 8/8] drivers/ptp/ptp_kvm.c:88:35: error: incompatible type for argument 1 of 'timespec_to_ktime'

[Radim Krčmář]

Another build failure with the PTP series happens while compiling as a
module,

  ERROR: "pvclock_pvti_cpu0_va" [drivers/ptp/ptp_kvm.ko] undefined!
  ERROR: "kvm_clock" [drivers/ptp/ptp_kvm.ko] undefined!
  make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1
  make: *** [Makefile:1198: modules] Error 2

the following two hunks got rid of that.


diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index 7c4317c00418..995fa260a6da 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -50,6 +50,7 @@ struct pvclock_vsyscall_time_info *pvclock_pvti_cpu0_va(void)
 {
 	return hv_clock;
 }
+EXPORT_SYMBOL_GPL(pvclock_pvti_cpu0_va);
 
 /*
  * The wallclock is the time of day when we booted. Since then, some time may
@@ -182,6 +183,7 @@ struct clocksource kvm_clock = {
 	.mask = CLOCKSOURCE_MASK(64),
 	.flags = CLOCK_SOURCE_IS_CONTINUOUS,
 };
+EXPORT_SYMBOL_GPL(kvm_clock);
 
 int kvm_register_clock(char *txt)
 {