From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] mbuf: use pktmbuf helper to create the pool
Date: Tue, 31 Jan 2017 11:32:04 +0100
Message-ID: <20170131113204.5d3b3df2@platinum>
References: <1484678576-3925-1-git-send-email-hemant.agrawal@nxp.com>
 <20170117133121.GA27592@santosh-Latitude-E5530-non-vPro>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, <dev@dpdk.org>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 43A733237
 for <dev@dpdk.org>; Tue, 31 Jan 2017 11:32:07 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id t18so18329442wmt.0
 for <dev@dpdk.org>; Tue, 31 Jan 2017 02:32:07 -0800 (PST)
In-Reply-To: <20170117133121.GA27592@santosh-Latitude-E5530-non-vPro>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Santosh,

On Tue, 17 Jan 2017 19:01:23 +0530, Santosh Shukla
<santosh.shukla@caviumnetworks.com> wrote:
> Hi Hemant,
> 
> On Wed, Jan 18, 2017 at 12:12:56AM +0530, Hemant Agrawal wrote:
> > When possible, replace the uses of rte_mempool_create() with
> > the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
> > 
> > This is the preferred way to create a mbuf pool.
> > 
> > This also updates the documentation.  
> 
> 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > This patch is derived from the RFC from Olivier:
> > http://dpdk.org/dev/patchwork/patch/15925/  
> 
> rte_mempool_create to _empty/populate OR rte_pktmbuf_pool_create
> changes missing for mempool testcases. do you have plan to take them
> up Or shall I post the patches? 

Not sure we should add something in test_mempool.c, since we are
converting to a mbuf api. As far as I can see,
rte_pktmbuf_pool_create() is already tested in test_mbuf.c.


Regards,
Olivier