All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, dovgaluk@ispras.ru,
	qemu-block@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] replay: disable default snapshot for record/replay
Date: Tue, 31 Jan 2017 14:57:45 +0300	[thread overview]
Message-ID: <20170131115745.5244.36762.stgit@PASHA-ISP> (raw)
In-Reply-To: <20170131115728.5244.21690.stgit@PASHA-ISP>

This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 vl.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index c6fc5c9..671fc04 100644
--- a/vl.c
+++ b/vl.c
@@ -3129,7 +3129,13 @@ int main(int argc, char **argv, char **envp)
                 drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
                 break;
             case QEMU_OPTION_snapshot:
-                snapshot = 1;
+                {
+                    Error *blocker = NULL;
+                    snapshot = 1;
+                    error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+                               "-snapshot");
+                    replay_add_blocker(blocker);
+                }
                 break;
             case QEMU_OPTION_hdachs:
                 {

  parent reply	other threads:[~2017-01-31 11:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 11:57 [Qemu-devel] [PATCH 0/3] block devices record/replay update Pavel Dovgalyuk
2017-01-31 11:57 ` [Qemu-devel] [PATCH 1/3] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-02-22 10:05   ` Kevin Wolf
2017-02-27 12:07     ` Pavel Dovgalyuk
2017-02-27 17:35       ` Kevin Wolf
2017-01-31 11:57 ` [Qemu-devel] [PATCH 2/3] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-02-22 10:24   ` Kevin Wolf
2017-01-31 11:57 ` Pavel Dovgalyuk [this message]
2017-02-22 10:28   ` [Qemu-devel] [PATCH 3/3] replay: disable default snapshot for record/replay Kevin Wolf
2017-02-13  5:04 ` [Qemu-devel] [PATCH 0/3] block devices record/replay update Pavel Dovgalyuk
2017-02-20  5:36   ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170131115745.5244.36762.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.