From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751993AbdAaM2p (ORCPT ); Tue, 31 Jan 2017 07:28:45 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33861 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdAaM2h (ORCPT ); Tue, 31 Jan 2017 07:28:37 -0500 From: Maksymilian Piechota X-Google-Original-From: Maksymilian Piechota Date: Tue, 31 Jan 2017 07:20:27 -0500 To: Joe Perches Cc: Maksymilian Piechota , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement Message-ID: <20170131122026.GA12809@maks-debian.localdomain> References: <20170130163142.GA9425@maks-debian.localdomain> <20170130164423.GA12941@kroah.com> <1485835236.20550.20.camel@perches.com> <20170131110358.GA11278@maks-debian.localdomain> <1485861525.20550.26.camel@perches.com> <20170131113332.GA12148@maks-debian.localdomain> <1485864424.20550.28.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1485864424.20550.28.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 04:07:04AM -0800, Joe Perches wrote: > On Tue, 2017-01-31 at 06:33 -0500, Maksymilian Piechota wrote: > > On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote: > > > checkpatch is just a guide, it's brainless. > > > > > > The reason these lines are > 80 columns is > > > overly long/verbose identifiers. > > > > > > If you really want to clean up the code here, > > > the P90211ENUM_ prefixes are a bit misleading > > > as they all are #define and not enums at all. > > > > > But would you like me to remove this prefixes for all of the enums from > > p80211types.h? Are you sure it won't cause any symbol conflicts? > > No, I don't want that, I'd prefer you think about it. > > Also, a useful effort would be to (from the README) > > TODO: > [] >         - move to use the in-kernel wireless stack > > where most all of the P80211 code would be removed. > > Anyway, sure, use checkpatch as a tool to help when > learning the process of how to submit patches properly. > Then move on to more thoroughly understand a block of > code in the kernel that can be improved with cleaner > style and logic and bug fixes you could submit. > > That's be much more appreciated than random 80 column > fixups and strict checkpatch compliance done without > a thorough understanding of the code. > > In any case, welcome, hope you stick around. It's clear that there are a lot more usefull patches than 80 column fix, but as you said, I learn how to submit patches and there is is constraint to submit only one checkpatch warning fix. Many thanks for advice how to proceed. I will take a look at it when I finish Greg's tutorial. Thank you, I hope to have a significant contribution to Linux Community.