From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752387AbdAaO0y (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Jan 2017 09:26:54 -0500
Received: from merlin.infradead.org ([205.233.59.134]:44634 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752028AbdAaO0r (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Jan 2017 09:26:47 -0500
Date: Tue, 31 Jan 2017 15:26:37 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <longman@redhat.com>
Cc: Jens Axboe <axboe@fb.com>, "J. R. Okajima" <hooanon05g@gmail.com>,
        linux-kernel@vger.kernel.org, darrick.wong@oracle.com,
        david@fromorbit.com, dave@stgolabs.net
Subject: Re: Q: lockdep_assert_held_read() after downgrade_write()
Message-ID: <20170131142637.GP6515@twins.programming.kicks-ass.net>
References: <18295.1485811542@jrobl>
 <86195df9-2a43-2a0f-38ac-68792edc41c0@fb.com>
 <20170131103620.GM6515@twins.programming.kicks-ass.net>
 <20170131112526.GH6536@twins.programming.kicks-ass.net>
 <9e2f505e-3d1f-3573-661a-b2ad185566b1@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9e2f505e-3d1f-3573-661a-b2ad185566b1@redhat.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2017 at 09:23:08AM -0500, Waiman Long wrote:
> On 01/31/2017 06:25 AM, Peter Zijlstra wrote:
> > @@ -40,8 +40,10 @@ static inline void rwsem_set_reader_owned(struct rw_semaphore *sem)
> >  	 * do a write to the rwsem cacheline when it is really necessary
> >  	 * to minimize cacheline contention.
> >  	 */
> > -	if (sem->owner != RWSEM_READER_OWNED)
> > +	if (sem->owner != RWSEM_READER_OWNED) {
> > +		WARN_ON_ONCE(sem->owner != current);
> >  		WRITE_ONCE(sem->owner, RWSEM_READER_OWNED);
> > +	}
> >  }
> >  
> >  static inline bool rwsem_owner_is_writer(struct task_struct *owner)
> 
> I don't think you can do a WARN_ON_ONCE() check for sem->owner !=
> current here. If the rwsem starts from an unlock state, sem->owner will
> be NULL and an incorrect warning message will be printed.

Argh, I only looked at the downgrade_write() user and forgot to look if
it was used elsewhere.