From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdAaNm3 (ORCPT ); Tue, 31 Jan 2017 08:42:29 -0500 Received: from mx2.suse.de ([195.135.220.15]:60629 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbdAaNmS (ORCPT ); Tue, 31 Jan 2017 08:42:18 -0500 Date: Tue, 31 Jan 2017 14:42:15 +0100 From: Jean Delvare To: Ricardo Ribalda Delgado Cc: Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: piix4: Fix request_region size Message-ID: <20170131144215.470703ae@endymion> In-Reply-To: <20170127145930.13055-1-ricardo.ribalda@gmail.com> References: <20170127145930.13055-1-ricardo.ribalda@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Wolfram, On Fri, 27 Jan 2017 15:59:30 +0100, Ricardo Ribalda Delgado wrote: > Since '701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")' we > are using the SMBSLVCNT register at offset 0x8. We need to request it. > > Fixes: 701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC") > Signed-off-by: Ricardo Ribalda Delgado > --- > Please note, not tested on hardware. > drivers/i2c/busses/i2c-piix4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c > index e34d82e79b98..73cc6799cc59 100644 > --- a/drivers/i2c/busses/i2c-piix4.c > +++ b/drivers/i2c/busses/i2c-piix4.c > @@ -58,7 +58,7 @@ > #define SMBSLVDAT (0xC + piix4_smba) > > /* count for request_region */ > -#define SMBIOSIZE 8 > +#define SMBIOSIZE 9 > > /* PCI Address Constants */ > #define SMBBA 0x090 I checked all the datasheets I have access to, and it should be good. Signed-off-by: Jean Delvare -- Jean Delvare SUSE L3 Support