From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdAaRtu (ORCPT ); Tue, 31 Jan 2017 12:49:50 -0500 Received: from mail.skyhub.de ([78.46.96.112]:48487 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdAaRt0 (ORCPT ); Tue, 31 Jan 2017 12:49:26 -0500 Date: Tue, 31 Jan 2017 18:49:06 +0100 From: Borislav Petkov To: Mike Galbraith Cc: Ingo Molnar , Andrey Ryabinin , Thomas Gleixner , LKML , "H. Peter Anvin" Subject: Re: [PATCH] x86/microcode: Do not access the initrd after it has been freed Message-ID: <20170131174906.vf635tw6qqjx2ayt@pd.tnic> References: <20170125192336.kmgxmwcffdo2gxrf@pd.tnic> <20170126165833.evjemhbqzaepirxo@pd.tnic> <7d07442a-c64e-797b-c8c4-ef453df30cde@virtuozzo.com> <20170127090915.zh7ct7cnvx2ds7qk@pd.tnic> <20170130084632.GA25091@gmail.com> <20170130093527.syjz7yldgndml7qb@pd.tnic> <20170131074355.GA17636@gmail.com> <20170131100122.r6ubk5z3t2vm3hxl@pd.tnic> <1485862277.4419.6.camel@gmx.de> <20170131123100.c6c6oal6ujbpixwk@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170131123100.c6c6oal6ujbpixwk@pd.tnic> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 01:31:00PM +0100, Borislav Petkov wrote: > On Tue, Jan 31, 2017 at 12:31:17PM +0100, Mike Galbraith wrote: > > (bisect fingered irqdomain: Avoid activating interrupts more than once) > > Yeah, that one is not kosher on x86. It broke IO-APIC timer on a box > here. Mike, does the below hunk fix the issue for ya? (Ontop of tip/master, without the revert). It does fix my APIC timer detection failure. --- diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 1e35dd06b090..52f352b063fd 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -2117,6 +2117,7 @@ static inline void __init check_timer(void) if (idx != -1 && irq_trigger(idx)) unmask_ioapic_irq(irq_get_chip_data(0)); } + irq_domain_deactivate_irq(irq_data); irq_domain_activate_irq(irq_data); if (timer_irq_works()) { if (disable_timer_pin_1 > 0) @@ -2138,6 +2139,7 @@ static inline void __init check_timer(void) * legacy devices should be connected to IO APIC #0 */ replace_pin_at_irq_node(data, node, apic1, pin1, apic2, pin2); + irq_domain_deactivate_irq(irq_data); irq_domain_activate_irq(irq_data); legacy_pic->unmask(0); if (timer_irq_works()) { diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 85e87b46c318..dc6ba5bda9fc 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -352,6 +352,7 @@ static int hpet_resume(struct clock_event_device *evt, int timer) } else { struct hpet_dev *hdev = EVT_TO_HPET_DEV(evt); + irq_domain_deactivate_irq(irq_get_irq_data(hdev->irq)); irq_domain_activate_irq(irq_get_irq_data(hdev->irq)); disable_irq(hdev->irq); irq_set_affinity(hdev->irq, cpumask_of(hdev->cpu)); -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.