From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbdAaVUF (ORCPT ); Tue, 31 Jan 2017 16:20:05 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34495 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdAaVUC (ORCPT ); Tue, 31 Jan 2017 16:20:02 -0500 Date: Tue, 31 Jan 2017 22:19:52 +0100 From: Daniel Vetter To: Thierry Reding Cc: Eric Anholt , Mark Rutland , Florian Fainelli , Stephen Warren , Michael Turquette , Lee Jones , Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/11] drm/panel: Add support for the Raspberry Pi 7" Touchscreen. Message-ID: <20170131211952.jirg7scbzajshpec@phenom.ffwll.local> Mail-Followup-To: Thierry Reding , Eric Anholt , Mark Rutland , Florian Fainelli , Stephen Warren , Michael Turquette , Lee Jones , Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-10-eric@anholt.net> <20170131210717.GA872@mithrandir.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170131210717.GA872@mithrandir.ba.sec> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 10:07:19PM +0100, Thierry Reding wrote: > On Wed, Dec 14, 2016 at 11:46:19AM -0800, Eric Anholt wrote: > > +static int rpi_touchscreen_dsi_remove(struct mipi_dsi_device *dsi) > > +{ > > + struct device *dev = &dsi->dev; > > + struct rpi_touchscreen *ts = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = mipi_dsi_detach(dsi); > > + if (ret < 0) { > > + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); > > + return ret; > > + } > > You might want to continue after this anyway, because the driver will be > unloaded regardless of your error code and you'll leave behind a > dangling panel and leak a reference to the I2C bridge. Sounds like we should switch the mipi_dsi_driver->remove callback to return void then? But separate cleanup series if someone bothers with it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Tue, 31 Jan 2017 22:19:52 +0100 Subject: [PATCH 09/11] drm/panel: Add support for the Raspberry Pi 7" Touchscreen. In-Reply-To: <20170131210717.GA872@mithrandir.ba.sec> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-10-eric@anholt.net> <20170131210717.GA872@mithrandir.ba.sec> Message-ID: <20170131211952.jirg7scbzajshpec@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 31, 2017 at 10:07:19PM +0100, Thierry Reding wrote: > On Wed, Dec 14, 2016 at 11:46:19AM -0800, Eric Anholt wrote: > > +static int rpi_touchscreen_dsi_remove(struct mipi_dsi_device *dsi) > > +{ > > + struct device *dev = &dsi->dev; > > + struct rpi_touchscreen *ts = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = mipi_dsi_detach(dsi); > > + if (ret < 0) { > > + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); > > + return ret; > > + } > > You might want to continue after this anyway, because the driver will be > unloaded regardless of your error code and you'll leave behind a > dangling panel and leak a reference to the I2C bridge. Sounds like we should switch the mipi_dsi_driver->remove callback to return void then? But separate cleanup series if someone bothers with it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/11] drm/panel: Add support for the Raspberry Pi 7" Touchscreen. Date: Tue, 31 Jan 2017 22:19:52 +0100 Message-ID: <20170131211952.jirg7scbzajshpec@phenom.ffwll.local> References: <20161214194621.16499-1-eric@anholt.net> <20161214194621.16499-10-eric@anholt.net> <20170131210717.GA872@mithrandir.ba.sec> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 106116E71A for ; Tue, 31 Jan 2017 21:19:57 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id v77so1020942wmv.0 for ; Tue, 31 Jan 2017 13:19:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170131210717.GA872@mithrandir.ba.sec> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Mark Rutland , Florian Fainelli , Stephen Warren , Michael Turquette , Lee Jones , Stephen Boyd , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMzEsIDIwMTcgYXQgMTA6MDc6MTlQTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gV2VkLCBEZWMgMTQsIDIwMTYgYXQgMTE6NDY6MTlBTSAtMDgwMCwgRXJpYyBB bmhvbHQgd3JvdGU6Cj4gPiArc3RhdGljIGludCBycGlfdG91Y2hzY3JlZW5fZHNpX3JlbW92ZShz dHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2kpCj4gPiArewo+ID4gKwlzdHJ1Y3QgZGV2aWNlICpk ZXYgPSAmZHNpLT5kZXY7Cj4gPiArCXN0cnVjdCBycGlfdG91Y2hzY3JlZW4gKnRzID0gZGV2X2dl dF9kcnZkYXRhKGRldik7Cj4gPiArCWludCByZXQ7Cj4gPiArCj4gPiArCXJldCA9IG1pcGlfZHNp X2RldGFjaChkc2kpOwo+ID4gKwlpZiAocmV0IDwgMCkgewo+ID4gKwkJZGV2X2VycigmZHNpLT5k ZXYsICJmYWlsZWQgdG8gZGV0YWNoIGZyb20gRFNJIGhvc3Q6ICVkXG4iLCByZXQpOwo+ID4gKwkJ cmV0dXJuIHJldDsKPiA+ICsJfQo+IAo+IFlvdSBtaWdodCB3YW50IHRvIGNvbnRpbnVlIGFmdGVy IHRoaXMgYW55d2F5LCBiZWNhdXNlIHRoZSBkcml2ZXIgd2lsbCBiZQo+IHVubG9hZGVkIHJlZ2Fy ZGxlc3Mgb2YgeW91ciBlcnJvciBjb2RlIGFuZCB5b3UnbGwgbGVhdmUgYmVoaW5kIGEKPiBkYW5n bGluZyBwYW5lbCBhbmQgbGVhayBhIHJlZmVyZW5jZSB0byB0aGUgSTJDIGJyaWRnZS4KClNvdW5k cyBsaWtlIHdlIHNob3VsZCBzd2l0Y2ggdGhlIG1pcGlfZHNpX2RyaXZlci0+cmVtb3ZlIGNhbGxi YWNrIHRvCnJldHVybiB2b2lkIHRoZW4/IEJ1dCBzZXBhcmF0ZSBjbGVhbnVwIHNlcmllcyBpZiBz b21lb25lIGJvdGhlcnMgd2l0aCBpdC4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==