From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbdBAIHE (ORCPT ); Wed, 1 Feb 2017 03:07:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56948 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbdBAIHD (ORCPT ); Wed, 1 Feb 2017 03:07:03 -0500 Date: Wed, 1 Feb 2017 09:07:06 +0100 From: Greg KH To: Stefan Agner Cc: balbi@kernel.org, andrzej.p@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line Message-ID: <20170201080706.GB17968@kroah.com> References: <20170201021917.27398-1-stefan@agner.ch> <20170201021917.27398-2-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170201021917.27398-2-stefan@agner.ch> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: > Other unsigned properties return hexadecimal values, follow this > convention when printing b_vendor_code too. Also add newlines to > the OS Descriptor support related properties, like other sysfs > files use. configfs is not sysfs, so watch out, you might not need/want those new lines as tools read the values and are not expecting them. Have you verified that nothing will break with this? How have you tested it? thanks, greg k-h