From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Date: Wed, 1 Feb 2017 07:24:56 -0600 Message-ID: <20170201132456.3dcprep7hwbii46n@rob-hp-laptop> References: <1485419634-28331-1-git-send-email-m.szyprowski@samsung.com> <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ot0-f196.google.com ([74.125.82.196]:34550 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbdBANY6 (ORCPT ); Wed, 1 Feb 2017 08:24:58 -0500 Content-Disposition: inline In-Reply-To: <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Marek Szyprowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Krzysztof Kozlowski , Linus Walleij , Tomasz Figa , Lee Jones , Bartlomiej Zolnierkiewicz On Thu, Jan 26, 2017 at 09:33:52AM +0100, Marek Szyprowski wrote: > Exynos LPASS requires some clocks to be enabled to make any access to its > registers. This patch adds code for handling such clocks. For current set > of registers it is enough to keep sfr0_ctrl clock enabled. Till now it > worked only because those clocks were enabled by bootloader and driver > probe() happened before they were disabled by clock core because of lack > of users. Handling those clocks is also needed to make it possible to > enable support for audio power domain. > > This patch requires adding sfr0_ctrl clock to device tree. > > Signed-off-by: Marek Szyprowski > --- > .../devicetree/bindings/mfd/samsung,exynos5433-lpass.txt | 6 ++++++ Acked-by: Rob Herring > drivers/mfd/exynos-lpass.c | 10 ++++++++++ > 2 files changed, 16 insertions(+) From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 1 Feb 2017 07:24:56 -0600 Subject: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks In-Reply-To: <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> References: <1485419634-28331-1-git-send-email-m.szyprowski@samsung.com> <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com> Message-ID: <20170201132456.3dcprep7hwbii46n@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 26, 2017 at 09:33:52AM +0100, Marek Szyprowski wrote: > Exynos LPASS requires some clocks to be enabled to make any access to its > registers. This patch adds code for handling such clocks. For current set > of registers it is enough to keep sfr0_ctrl clock enabled. Till now it > worked only because those clocks were enabled by bootloader and driver > probe() happened before they were disabled by clock core because of lack > of users. Handling those clocks is also needed to make it possible to > enable support for audio power domain. > > This patch requires adding sfr0_ctrl clock to device tree. > > Signed-off-by: Marek Szyprowski > --- > .../devicetree/bindings/mfd/samsung,exynos5433-lpass.txt | 6 ++++++ Acked-by: Rob Herring > drivers/mfd/exynos-lpass.c | 10 ++++++++++ > 2 files changed, 16 insertions(+)