All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrii Anisov <andrii.anisov@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Andrii Anisov <andrii_anisov@epam.com>,
	Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
Subject: Re: [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback
Date: Wed, 1 Feb 2017 09:25:46 -0500	[thread overview]
Message-ID: <20170201142545.GI20958@char.us.ORACLE.com> (raw)
In-Reply-To: <CAC1WxdjDgkejB1bkYDHrH8A0WKxu+WxEahPbx3Za2Pd2H192Bg@mail.gmail.com>

On Wed, Feb 01, 2017 at 12:46:32PM +0200, Andrii Anisov wrote:
> Yup,
> 
> Following is wrong:
> > DEBUG macro could be globally across drivers defined by
> > CONFIG_DEBUG_DRIVERS. See drivers/base/Makefile.
> DEBUG is not defined globally. And there is no debug option to enable
> DEBUG in drivers/xen/Makefile.
> Should it be added?

I am not exactly sure why you guys insist on having this, but
the lets leave it as #if 0 along with a comment saying why and what
the purpose of this is.

> 
> Sincerely,
> Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-02-01 14:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 18:30 [PATCH v3 0/2] XEN SWIOTLB dma operations extension Andrii Anisov
2017-01-31 18:30 ` [PATCH v3 1/2] swiotlb-xen: implement xen_swiotlb_dma_mmap callback Andrii Anisov
2017-01-31 18:39   ` Konrad Rzeszutek Wilk
2017-01-31 19:10     ` Stefano Stabellini
2017-02-01 11:46       ` Andrii Anisov
2017-02-01 14:24         ` Konrad Rzeszutek Wilk
2017-01-31 18:30 ` [PATCH v3 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback Andrii Anisov
2017-01-31 18:37   ` Konrad Rzeszutek Wilk
2017-01-31 19:15     ` Stefano Stabellini
2017-01-31 19:17       ` Konrad Rzeszutek Wilk
2017-01-31 19:21         ` Stefano Stabellini
2017-02-01 10:42           ` Andrii Anisov
2017-02-01 10:57             ` Julien Grall
2017-02-01 10:58               ` Julien Grall
2017-02-01 10:19         ` Andrii Anisov
2017-02-01 10:46           ` Andrii Anisov
2017-02-01 14:25             ` Konrad Rzeszutek Wilk [this message]
2017-02-01 14:30               ` Julien Grall
2017-02-01 15:11                 ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170201142545.GI20958@char.us.ORACLE.com \
    --to=konrad.wilk@oracle.com \
    --cc=andrii.anisov@gmail.com \
    --cc=andrii_anisov@epam.com \
    --cc=julien.grall@arm.com \
    --cc=oleksandr.dmytryshyn@globallogic.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.