From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: oder_chiou@realtek.com, jack.yu@realtek.com,
alsa-devel@alsa-project.org, lars@metafoo.de,
lgirdwood@gmail.com, shumingf@realtek.com,
Bard Liao <bardliao@realtek.com>,
flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5670: add HS ground control
Date: Wed, 1 Feb 2017 17:43:59 +0000 [thread overview]
Message-ID: <20170201174359.buiiybffgk6ya62d@sirena.org.uk> (raw)
In-Reply-To: <s5ha8a6apux.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]
On Wed, Feb 01, 2017 at 04:32:38PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > Sure, it works on that one machine but if someone else did something
> > similar but using a different GPIO it (from what I remember) might not
> > work.
> For other GPIO pin, you'll need to write another similar codes, sure.
> But why do you need to worry so much about it? It doesn't work even
> without this patch, and a complete generalization isn't so trivial,
> I'm afraid, as it's anyway pretty device-specific.
I don't know, I need to figure this stuff out which is why the patch is
still in the queue. If it is just using a regular GPIO then gpiolib is
pretty trivial to use.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-02-01 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 8:23 [PATCH] ASoC: rt5670: add HS ground control Bard Liao
2017-01-02 12:03 ` Takashi Iwai
2017-01-30 9:58 ` Takashi Iwai
2017-02-01 11:47 ` Mark Brown
2017-02-01 12:52 ` Takashi Iwai
2017-02-01 14:59 ` Mark Brown
2017-02-01 15:32 ` Takashi Iwai
2017-02-01 17:43 ` Mark Brown [this message]
[not found] ` <ABFD875FF5FB574BA706497D987D48D70124DF38@RTITMBSV03.realtek.com.tw>
2017-02-04 16:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201174359.buiiybffgk6ya62d@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.