From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207AbdBASXw (ORCPT ); Wed, 1 Feb 2017 13:23:52 -0500 Received: from mga03.intel.com ([134.134.136.65]:34777 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbdBASXu (ORCPT ); Wed, 1 Feb 2017 13:23:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="1120788996" Date: Wed, 1 Feb 2017 20:23:46 +0200 From: Jarkko Sakkinen To: Mimi Zohar Cc: James Morris , Kenneth Goldman , "moderated list:TPM DEVICE DRIVER" , open list , linux-security-module@vger.kernel.org Subject: Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log Message-ID: <20170201182346.az2nkssotenb4i5m@intel.com> References: <588F09A2.4090502@linux.vnet.ibm.com> <20170131174659.b6njebycqzd5ur6f@intel.com> <20170131203452.523ckw4aphxdsndq@intel.com> <1485901910.9008.1.camel@linux.vnet.ibm.com> <20170201103003.ltiqrfukfyoognx2@intel.com> <1485956970.4068.31.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485956970.4068.31.camel@linux.vnet.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 01, 2017 at 08:49:30AM -0500, Mimi Zohar wrote: > On Wed, 2017-02-01 at 12:30 +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 31, 2017 at 05:31:50PM -0500, Mimi Zohar wrote: > > > On Wed, 2017-02-01 at 08:46 +1100, James Morris wrote: > > > > On Tue, 31 Jan 2017, Jarkko Sakkinen wrote: > > > > > > > > > James, > > > > > > > > > > The discussion is about two features: > > > > > > > > > > 1. Extension to tpm_pcr_extend() (used by IMA) to extend all PCR banks > > > > > instead of just SHA-1 banks. It is recommended by TCG to do so in > > > > > order to prevent malicious use of PCRs. > > > > > 2. TPM 2.0 event log with backend support for OF device tree (for > > > > > getting address where you can grab it). > > > > > > > > > > These are required as baseline to implement full TPM 2.0 support for > > > > > IMA. The commits are fairly well baked and went through many iterations. > > > > > I've tested tpm_pcr_extend() patches. I haven't tested event log patches > > > > > but have extensively reviewed them and Ken Goldman has tested them with > > > > > POWER hardware. > > > > > > > > > > I don't believe that there is major risk to put them already into 4.11 > > > > > but it is fairly late so I just want a second opinion before putting > > > > > them into pull request. > > > > > > > > > > > > > I'll take this for 4.11. IMA + TPM 2.0 is still developmental and not in > > > > wide use, afaik. > > > > > > Thank you! FYI, I've been running with them as well. > > > > > > Mimi > > > > OK, so can I also add your Tested-by to these four commits? > > I provided Ken with the firmware event log, IMA measurement list, and > the PCRs for testing. Ken's tested-by is fine. Missing is Stefan's > tested-by - https://sourceforge.net/p/tpmdd/mailman/message/35602588/ > I would really appreciate your adding his tested-by. > > thanks, > > Mimi Sure, I'll add it. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log Date: Wed, 1 Feb 2017 20:23:46 +0200 Message-ID: <20170201182346.az2nkssotenb4i5m@intel.com> References: <588F09A2.4090502@linux.vnet.ibm.com> <20170131174659.b6njebycqzd5ur6f@intel.com> <20170131203452.523ckw4aphxdsndq@intel.com> <1485901910.9008.1.camel@linux.vnet.ibm.com> <20170201103003.ltiqrfukfyoognx2@intel.com> <1485956970.4068.31.camel@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1485956970.4068.31.camel@linux.vnet.ibm.com> Sender: owner-linux-security-module@vger.kernel.org To: Mimi Zohar Cc: James Morris , Kenneth Goldman , "moderated list:TPM DEVICE DRIVER" , open list , linux-security-module@vger.kernel.org List-Id: tpmdd-devel@lists.sourceforge.net On Wed, Feb 01, 2017 at 08:49:30AM -0500, Mimi Zohar wrote: > On Wed, 2017-02-01 at 12:30 +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 31, 2017 at 05:31:50PM -0500, Mimi Zohar wrote: > > > On Wed, 2017-02-01 at 08:46 +1100, James Morris wrote: > > > > On Tue, 31 Jan 2017, Jarkko Sakkinen wrote: > > > > > > > > > James, > > > > > > > > > > The discussion is about two features: > > > > > > > > > > 1. Extension to tpm_pcr_extend() (used by IMA) to extend all PCR banks > > > > > instead of just SHA-1 banks. It is recommended by TCG to do so in > > > > > order to prevent malicious use of PCRs. > > > > > 2. TPM 2.0 event log with backend support for OF device tree (for > > > > > getting address where you can grab it). > > > > > > > > > > These are required as baseline to implement full TPM 2.0 support for > > > > > IMA. The commits are fairly well baked and went through many iterations. > > > > > I've tested tpm_pcr_extend() patches. I haven't tested event log patches > > > > > but have extensively reviewed them and Ken Goldman has tested them with > > > > > POWER hardware. > > > > > > > > > > I don't believe that there is major risk to put them already into 4.11 > > > > > but it is fairly late so I just want a second opinion before putting > > > > > them into pull request. > > > > > > > > > > > > > I'll take this for 4.11. IMA + TPM 2.0 is still developmental and not in > > > > wide use, afaik. > > > > > > Thank you! FYI, I've been running with them as well. > > > > > > Mimi > > > > OK, so can I also add your Tested-by to these four commits? > > I provided Ken with the firmware event log, IMA measurement list, and > the PCRs for testing. Ken's tested-by is fine. Missing is Stefan's > tested-by - https://sourceforge.net/p/tpmdd/mailman/message/35602588/ > I would really appreciate your adding his tested-by. > > thanks, > > Mimi Sure, I'll add it. /Jarkko