All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 04/46] drm/i915: Flush the freed object queue on device release
Date: Thu,  2 Feb 2017 09:08:23 +0000	[thread overview]
Message-ID: <20170202090905.29028-5-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20170202090905.29028-1-chris@chris-wilson.co.uk>

As dmabufs may live beyond the PCI device removal, we need to flush the
freed object worker on device release, and include a warning in case
there is a leak.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 6c7a83bbd068..88065fd55147 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4625,7 +4625,9 @@ i915_gem_load_init(struct drm_i915_private *dev_priv)
 
 void i915_gem_load_cleanup(struct drm_i915_private *dev_priv)
 {
+	i915_gem_drain_freed_objects(dev_priv);
 	WARN_ON(!llist_empty(&dev_priv->mm.free_list));
+	WARN_ON(dev_priv->mm.object_count);
 
 	mutex_lock(&dev_priv->drm.struct_mutex);
 	i915_gem_timeline_fini(&dev_priv->gt.global_timeline);
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-02-02  9:09 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02  9:08 Moah selftests Chris Wilson
2017-02-02  9:08 ` [PATCH 01/46] drm: Provide a driver hook for drm_dev_release() Chris Wilson
2017-02-02  9:24   ` Laurent Pinchart
2017-02-02  9:36   ` [PATCH v6] " Chris Wilson
2017-02-02  9:44     ` Daniel Vetter
2017-02-02  9:08 ` [PATCH 02/46] drm/i915: Split device release from unload Chris Wilson
2017-02-08 13:41   ` Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 03/46] drm/i915: Unbind any residual objects/vma from the Global GTT on shutdown Chris Wilson
2017-02-08 13:36   ` Joonas Lahtinen
2017-02-02  9:08 ` Chris Wilson [this message]
2017-02-08 13:38   ` [PATCH 04/46] drm/i915: Flush the freed object queue on device release Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 05/46] drm/i915: Provide a hook for selftests Chris Wilson
2017-02-02  9:11   ` Chris Wilson
2017-02-10 10:19   ` Tvrtko Ursulin
2017-02-10 10:36     ` Chris Wilson
2017-02-02  9:08 ` [PATCH 06/46] drm/i915: Add some selftests for sg_table manipulation Chris Wilson
2017-02-10 10:24   ` Tvrtko Ursulin
2017-02-10 10:43     ` Chris Wilson
2017-02-10 12:01       ` Tvrtko Ursulin
2017-02-02  9:08 ` [PATCH 07/46] drm/i915: Add unit tests for the breadcrumb rbtree, insert/remove Chris Wilson
2017-02-02  9:08 ` [PATCH 08/46] drm/i915: Add unit tests for the breadcrumb rbtree, completion Chris Wilson
2017-02-02  9:08 ` [PATCH 09/46] drm/i915: Add unit tests for the breadcrumb rbtree, wakeups Chris Wilson
2017-02-02 12:49   ` Tvrtko Ursulin
2017-02-02 13:02     ` Chris Wilson
2017-02-02  9:08 ` [PATCH 10/46] drm/i915: Mock the GEM device for self-testing Chris Wilson
2017-02-02  9:08 ` [PATCH 11/46] drm/i915: Mock a GGTT " Chris Wilson
2017-02-02  9:08 ` [PATCH 12/46] drm/i915: Mock infrastructure for request emission Chris Wilson
2017-02-02  9:08 ` [PATCH 13/46] drm/i915: Create a fake object for testing huge allocations Chris Wilson
2017-02-02  9:08 ` [PATCH 14/46] drm/i915: Add selftests for i915_gem_request Chris Wilson
2017-02-02  9:08 ` [PATCH 15/46] drm/i915: Add a simple request selftest for waiting Chris Wilson
2017-02-02  9:08 ` [PATCH 16/46] drm/i915: Add a simple fence selftest to i915_gem_request Chris Wilson
2017-02-02  9:08 ` [PATCH 17/46] drm/i915: Simple selftest to exercise live requests Chris Wilson
2017-02-02  9:08 ` [PATCH 18/46] drm/i915: Test simultaneously submitting requests to all engines Chris Wilson
2017-02-02  9:08 ` [PATCH 19/46] drm/i915: Test request ordering between engines Chris Wilson
2017-02-09 10:20   ` Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 20/46] drm/i915: Live testing of empty requests Chris Wilson
2017-02-09 10:30   ` Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 21/46] drm/i915: Add selftests for object allocation, phys Chris Wilson
2017-02-02 13:10   ` Matthew Auld
2017-02-02 13:20     ` Chris Wilson
2017-02-02  9:08 ` [PATCH 22/46] drm/i915: Add a live seftest for GEM objects Chris Wilson
2017-02-02  9:08 ` [PATCH 23/46] drm/i915: Test partial mappings Chris Wilson
2017-02-02  9:08 ` [PATCH 24/46] drm/i915: Test exhaustion of the mmap space Chris Wilson
2017-02-02  9:08 ` [PATCH 25/46] drm/i915: Test coherency of and barriers between cache domains Chris Wilson
2017-02-02  9:08 ` [PATCH 26/46] drm/i915: Move uncore selfchecks to live selftest infrastructure Chris Wilson
2017-02-02  9:08 ` [PATCH 27/46] drm/i915: Test all fw tables during mock selftests Chris Wilson
2017-02-02  9:08 ` [PATCH 28/46] drm/i915: Sanity check all registers for matching fw domains Chris Wilson
2017-02-02  9:08 ` [PATCH 29/46] drm/i915: Add some mock tests for dmabuf interop Chris Wilson
2017-02-02  9:08 ` [PATCH 30/46] drm/i915: Add a live dmabuf selftest Chris Wilson
2017-02-09 10:59   ` Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 31/46] drm/i915: Add initial selftests for i915_gem_gtt Chris Wilson
2017-02-02  9:08 ` [PATCH 32/46] drm/i915: Exercise filling the top/bottom portions of the ppgtt Chris Wilson
2017-02-09 10:49   ` Joonas Lahtinen
2017-02-02  9:08 ` [PATCH 33/46] drm/i915: Exercise filling the top/bottom portions of the global GTT Chris Wilson
2017-02-02  9:08 ` [PATCH 34/46] drm/i915: Fill different pages of the GTT Chris Wilson
2017-02-02  9:08 ` [PATCH 35/46] drm/i915: Exercise filling and removing random ranges from the live GTT Chris Wilson
2017-02-02  9:08 ` [PATCH 36/46] drm/i915: Test creation of VMA Chris Wilson
2017-02-02  9:08 ` [PATCH 37/46] drm/i915: Exercise i915_vma_pin/i915_vma_insert Chris Wilson
2017-02-02  9:08 ` [PATCH 38/46] drm/i915: Verify page layout for rotated VMA Chris Wilson
2017-02-02 13:01   ` Tvrtko Ursulin
2017-02-02  9:08 ` [PATCH 39/46] drm/i915: Test creation of partial VMA Chris Wilson
2017-02-02  9:08 ` [PATCH 40/46] drm/i915: Live testing for context execution Chris Wilson
2017-02-02  9:09 ` [PATCH 41/46] drm/i915: Initial selftests for exercising eviction Chris Wilson
2017-02-02  9:09 ` [PATCH 42/46] drm/i915: Add mock exercise for i915_gem_gtt_reserve Chris Wilson
2017-02-02  9:09 ` [PATCH 43/46] drm/i915: Add mock exercise for i915_gem_gtt_insert Chris Wilson
2017-02-02  9:09 ` [PATCH 44/46] drm/i915: Add mock tests for GTT/VMA handling Chris Wilson
2017-02-08 12:12   ` Matthew Auld
2017-02-09 10:53   ` Joonas Lahtinen
2017-02-02  9:09 ` [PATCH 45/46] drm/i915: Exercise manipulate of single pages in the GGTT Chris Wilson
2017-02-08 12:25   ` Matthew Auld
2017-02-08 12:33     ` Chris Wilson
2017-02-02  9:09 ` [PATCH 46/46] drm/i915: Add initial selftests for hang detection and resets Chris Wilson
2017-02-02 13:28   ` Mika Kuoppala
2017-02-02  9:18 ` [PATCH igt] intel-ci: Add all driver selftests to BAT Chris Wilson
2017-02-02 13:30   ` Maarten Lankhorst
2017-02-02 13:44     ` Chris Wilson
2017-02-02 14:11       ` Maarten Lankhorst
2017-02-02 15:42       ` Saarinen, Jani
2017-02-17 11:50   ` Petri Latvala
2017-02-17 11:57     ` Chris Wilson
2017-02-02 11:32 ` ✗ Fi.CI.BAT: failure for series starting with [v6] drm: Provide a driver hook for drm_dev_release() (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170202090905.29028-5-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.