From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: guillaume.gaudonville@6wind.com, dev@dpdk.org,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH 1/3] net/mlx5: fix Ethernet header re-writing
Date: Thu, 2 Feb 2017 17:38:31 +0100 [thread overview]
Message-ID: <20170202163831.GS16389@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <36c259d4-ed03-75b2-43ea-3de28facf1dc@intel.com>
Hi Ferruh,
On Thu, Feb 02, 2017 at 03:34:04PM +0000, Ferruh Yigit wrote:
> On 2/2/2017 10:34 AM, Nelio Laranjeiro wrote:
> > First two bytes of the Ethernet header was written twice at the same place.
>
> Is this patch just prevents re-writing 2 bytes of buffer, or changes the
> buffer content as well?
It only prevents to re-write 2 bytes of the buffer.
> If buffer content also updated, I think it would be nice to mention in
> the commit log.
The buffer is only read.
> And if buffer content is not changed, will it be fair to say this patch
> is refactor patch instead of fix?
Well, I understand that it can be seen as not being a fix as the final
behavior remains the same. Is it possible to change it to:
"net/mlx5: avoid re-writing first 2 bytes of Ethernet header"
> > Fixes: b8fe952ec5b6 ("net/mlx5: prepare Tx vectorization")
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> <...>
Regards,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-02-02 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 10:34 [PATCH 1/3] net/mlx5: fix Ethernet header re-writing Nelio Laranjeiro
2017-02-02 10:34 ` [PATCH 2/3] net/mlx5: fix Tx WQE corruption caused by starvation Nelio Laranjeiro
2017-02-02 10:34 ` [PATCH 3/3] net/mlx5: fix inline WQE consumption Nelio Laranjeiro
2017-02-02 15:34 ` [PATCH 1/3] net/mlx5: fix Ethernet header re-writing Ferruh Yigit
2017-02-02 16:38 ` Nélio Laranjeiro [this message]
2017-02-02 21:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202163831.GS16389@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guillaume.gaudonville@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.