From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>,
Fam Zheng <famz@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/6] qemu-img: improve convert & dd commands
Date: Fri, 3 Feb 2017 12:02:48 +0000 [thread overview]
Message-ID: <20170203120254.15062-1-berrange@redhat.com> (raw)
Update to
v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html
This series is in response to Max pointing out that you cannot
use 'convert' for an encrypted target image.
The 'convert' and 'dd' commands need to first create the image
and then open it. The bdrv_create() method takes a set of options
for creating the image, which let us provide a key-secret for the
encryption key. When the commands then open the new image, they
don't provide any options, so the image is unable to be opened
due to lack of encryption key. It is also not possible to use
the --image-opts argument to provide structured options in the
target image name - it must be a plain filename to satisfy the
bdrv_create() API contract.
This series addresses these problems to some extent
- Adds a new --target-image-opts flag which is used to say
that the target filename is using structured options.
It is *only* permitted to use this when -n is also set.
ie the target image must be pre-created so convert/dd
don't need to run bdrv_create().
- When --target-image-opts is not used, add special case
code that identifies options passed to bdrv_create()
named "*key-secret" and adds them to the options used
to open the new image
In future it is desirable to make --target-image-opts work
even when -n is *not* given. This requires considerable
work to create a new bdrv_create() API impl.
The first four patches improve the 'dd' command to address
feature gaps wrt the 'convert' command. The last two patches
implement the improvements described above.
Changed in v2:
- Replace dd -n flag with support for conv=nocreat,notrunc
- Misc typos (Eric, Fam)
Daniel P. Berrange (6):
qemu-img: add support for --object with 'dd' command
qemu-img: fix --image-opts usage with dd command
qemu-img: add support for conv=nocreat,notrunc args to dd command
qemu-img: add support for -o arg to dd command
qemu-img: introduce --target-image-opts for 'convert' command
qemu-img: copy *key-secret opts when opening newly created files
qemu-img-cmds.hx | 8 +-
qemu-img.c | 342 ++++++++++++++++++++++++++++++++++++++++++++-----------
qemu-img.texi | 26 ++++-
3 files changed, 299 insertions(+), 77 deletions(-)
--
2.9.3
next reply other threads:[~2017-02-03 12:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 12:02 Daniel P. Berrange [this message]
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 1/6] qemu-img: add support for --object with 'dd' command Daniel P. Berrange
2017-02-03 21:01 ` Max Reitz
2017-02-20 12:32 ` Daniel P. Berrange
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 2/6] qemu-img: fix --image-opts usage with dd command Daniel P. Berrange
2017-02-03 21:08 ` Max Reitz
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 3/6] qemu-img: add support for conv=nocreat, notrunc args to " Daniel P. Berrange
2017-02-03 21:44 ` Max Reitz
2017-02-20 12:33 ` Daniel P. Berrange
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 4/6] qemu-img: add support for -o arg " Daniel P. Berrange
2017-02-03 22:07 ` Max Reitz
2017-02-20 12:33 ` Daniel P. Berrange
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 5/6] qemu-img: introduce --target-image-opts for 'convert' command Daniel P. Berrange
2017-02-03 22:32 ` Max Reitz
2017-02-20 12:44 ` Daniel P. Berrange
2017-02-03 12:02 ` [Qemu-devel] [PATCH v2 6/6] qemu-img: copy *key-secret opts when opening newly created files Daniel P. Berrange
2017-02-03 22:39 ` Max Reitz
2017-02-20 12:46 ` Daniel P. Berrange
2017-02-20 15:13 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203120254.15062-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.