From: Tony Lindgren <tony@atomide.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Liam Breck <kernel@networkimprov.net>,
"Mark A . Greer" <mgreer@animalcreek.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend
Date: Fri, 3 Feb 2017 14:28:13 -0800 [thread overview]
Message-ID: <20170203222812.GA3900@atomide.com> (raw)
In-Reply-To: <CAKvHMgQwhm3pBupBj8KFLwyhZpdeHtMyKj3BardbKpcAy_qXfg@mail.gmail.com>
* Liam Breck <liam@networkimprov.net> [170203 13:46]:
> On Fri, Feb 3, 2017 at 1:17 PM, Tony Lindgren <tony@atomide.com> wrote:
> > Cc: Liam Breck <kernel@networkimprov.net>
> > Acked-by: Mark Greer <mgreer@animalcreek.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Liam Breck <kernel@networkimprov.net>
Thanks for looking though it.
> > @@ -1492,15 +1553,25 @@ static int bq24190_pm_resume(struct device *dev)
> > {
> > struct i2c_client *client = to_i2c_client(dev);
> > struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> > + int error;
> >
> > bdi->f_reg = 0;
> > bdi->ss_reg = BQ24190_REG_SS_VBUS_STAT_MASK; /* impossible state */
> >
> > - pm_runtime_get_sync(bdi->dev);
> > + error = pm_runtime_get_sync(bdi->dev);
> > + if (error < 0) {
> > + pm_runtime_put_noidle(bdi->dev);
> > + dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> > + }
>
> Last nitpick: call put_noidle after dev_warn, as in suspend :-)
Sure, will do that and repost v3 of both patches shortly.
Regards,
Tony
next prev parent reply other threads:[~2017-02-03 22:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 0:02 [PATCHv2 0/2] Two bq24190 PM improvments Tony Lindgren
2017-01-31 0:02 ` [PATCH 1/2] power: bq24190_charger: Check the interrupt status on resume Tony Lindgren
2017-02-03 0:32 ` Liam Breck
2017-01-31 0:02 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-01-31 0:14 ` Liam Breck
2017-01-31 0:36 ` Tony Lindgren
2017-02-03 1:43 ` Liam Breck
2017-02-03 3:44 ` Tony Lindgren
2017-02-03 10:38 ` Liam Breck
2017-02-03 18:54 ` Tony Lindgren
2017-02-03 21:00 ` Liam Breck
2017-02-03 21:17 ` Tony Lindgren
2017-02-03 21:44 ` Liam Breck
2017-02-03 22:28 ` Tony Lindgren [this message]
2017-02-04 0:23 ` Liam Breck
2017-02-07 16:01 ` Tony Lindgren
2017-02-07 18:20 ` Liam Breck
-- strict thread matches above, loose matches on Subject: below --
2017-02-08 23:12 [PATCHv4 0/2] Two bq24190 PM improvments Tony Lindgren
2017-02-08 23:13 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-02-03 23:09 [PATCHv3 0/2] Two bq24190 PM improvments Tony Lindgren
2017-02-03 23:09 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-02-08 21:32 ` Tony Lindgren
2017-01-20 22:04 [PATCH 0/2] Two bq24190 PM improvments Tony Lindgren
2017-01-20 22:04 ` [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-01-21 0:47 ` Liam Breck
2017-01-24 1:27 ` Tony Lindgren
2017-01-24 3:34 ` Liam Breck
2017-01-24 18:29 ` Tony Lindgren
2017-01-24 23:05 ` Mark Greer
2017-01-26 16:20 ` Tony Lindgren
2017-01-26 23:56 ` Liam Breck
2017-01-30 23:55 ` Tony Lindgren
2017-01-31 0:01 ` Liam Breck
2017-01-31 0:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203222812.GA3900@atomide.com \
--to=tony@atomide.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.