All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
@ 2017-02-03 23:56 Derek Robson
  2017-02-04  2:41 ` kbuild test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Derek Robson @ 2017-02-03 23:56 UTC (permalink / raw)
  To: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, robsonde
  Cc: speakup, devel, linux-kernel

Changed function definition argument to have identifier name.
found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/speakup/spk_priv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
index 98c4b6f0344a..1952d7887b3b 100644
--- a/drivers/staging/speakup/spk_priv.h
+++ b/drivers/staging/speakup/spk_priv.h
@@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
 int spk_synth_is_alive_nop(struct spk_synth *synth);
 int spk_synth_is_alive_restart(struct spk_synth *synth);
 void synth_printf(const char *buf, ...);
-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)
 int synth_add(struct spk_synth *in_synth);
 void synth_remove(struct spk_synth *in_synth);
 
-- 
2.11.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
  2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
@ 2017-02-04  2:41 ` kbuild test robot
  2017-02-04  3:31   ` Derek Robson
  2017-02-04  2:53 ` kbuild test robot
  2017-02-04  4:31 ` Guenter Roeck
  2 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2017-02-04  2:41 UTC (permalink / raw)
  To: Derek Robson
  Cc: kbuild-all, w.d.hubbs, chris, kirk, samuel.thibault, gregkh,
	robsonde, devel, speakup, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 51619 bytes --]

Hi Derek,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.10-rc6 next-20170203]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

    #define param_check_int(name, p) __param_check(name, p, int)
                                     ^~~~~~~~~~~~~
   include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
     param_check_##type(name, &(value));       \
     ^~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
     param_check_##type(name, &(value));       \
                                       ^
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
     static const char __param_str_##name[] = prefix #name;  \
                       ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:146:36: error: parameter '__param_str_ser' is initialized
     param_check_##type(name, &(value));       \
                                       ^
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: storage class specified for parameter '__param_ser'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:16: error: parameter '__param_ser' is initialized
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:16: warning: '__used__' attribute ignored [-Wattributes]
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: section attribute not allowed for '__param_ser'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: alignment may not be specified for '__param_ser'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: storage class specified for parameter '__UNIQUE_ID_sertype12'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/thread_info.h:11:0,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/wait.h:8,
                    from include/linux/fs.h:5,
                    from drivers/staging/speakup/spk_types.h:7,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/bug.h:37:45: error: parameter '__UNIQUE_ID_sertype12' is initialized
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:868:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/bug.h:37:45: warning: '__used__' attribute ignored [-Wattributes]
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:868:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: section attribute not allowed for '__UNIQUE_ID_sertype12'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: alignment may not be specified for '__UNIQUE_ID_sertype12'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
    module_param_named(ser, synth_acntsa.ser, int, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/module.h:18:0,
                    from drivers/staging/speakup/spk_types.h:12,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/moduleparam.h:344:59: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     static inline type __always_unused *__check_##name(void) { return(p); }
                                                              ^
   include/linux/moduleparam.h:354:36: note: in expansion of macro '__param_check'
    #define param_check_short(name, p) __param_check(name, p, short)
                                       ^~~~~~~~~~~~~
   include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_short'
     param_check_##type(name, &(value));       \
     ^~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
     param_check_##type(name, &(value));       \
                                       ^
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_start'
     static const char __param_str_##name[] = prefix #name;  \
                       ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:146:36: error: parameter '__param_str_start' is initialized
     param_check_##type(name, &(value));       \
                                       ^
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: storage class specified for parameter '__param_start'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:16: error: parameter '__param_start' is initialized
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:16: warning: '__used__' attribute ignored [-Wattributes]
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: section attribute not allowed for '__param_start'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:221:49: error: alignment may not be specified for '__param_start'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: storage class specified for parameter '__UNIQUE_ID_starttype13'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/linux/thread_info.h:11:0,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/wait.h:8,
                    from include/linux/fs.h:5,
                    from drivers/staging/speakup/spk_types.h:7,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/bug.h:37:45: error: parameter '__UNIQUE_ID_starttype13' is initialized
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:868:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   include/linux/bug.h:37:45: warning: '__used__' attribute ignored [-Wattributes]
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:868:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^~~~~~~~~~~~~~~~~~~
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: section attribute not allowed for '__UNIQUE_ID_starttype13'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: alignment may not be specified for '__UNIQUE_ID_starttype13'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^~~~~~~~~~~~~
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^~~~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:137:1: note: in expansion of macro 'module_param_named'
    module_param_named(start, synth_acntsa.startup, short, 0444);
    ^~~~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: storage class specified for parameter '__UNIQUE_ID_ser14'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:139:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
    ^~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup_acntsa.c:139:1: error: parameter '__UNIQUE_ID_ser14' is initialized
>> drivers/staging/speakup/speakup_acntsa.c:139:1: warning: '__used__' attribute ignored [-Wattributes]
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: section attribute not allowed for '__UNIQUE_ID_ser14'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:139:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
    ^~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: alignment may not be specified for '__UNIQUE_ID_ser14'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:139:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
    ^~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: storage class specified for parameter '__UNIQUE_ID_start15'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:140:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded.");
    ^~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup_acntsa.c:140:1: error: parameter '__UNIQUE_ID_start15' is initialized
   drivers/staging/speakup/speakup_acntsa.c:140:1: warning: '__used__' attribute ignored [-Wattributes]
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: section attribute not allowed for '__UNIQUE_ID_start15'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:140:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded.");
    ^~~~~~~~~~~~~~~~
>> include/linux/compiler-gcc.h:182:45: error: alignment may not be specified for '__UNIQUE_ID_start15'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/moduleparam.h:35:2: note: in expansion of macro '__MODULE_INFO'
     __MODULE_INFO(parm, _parm, #_parm ":" desc)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:140:1: note: in expansion of macro 'MODULE_PARM_DESC'
    MODULE_PARM_DESC(start, "Start the synthesizer once it is loaded.");
    ^~~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/spk_types.h:17:0,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/device.h:1460:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    { \
    ^
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/spk_types.h:12:0,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/module.h:131:2: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     { return initfn; }     \
     ^
   include/linux/device.h:1463:1: note: in expansion of macro 'module_init'
    module_init(__driver##_init); \
    ^~~~~~~~~~~
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   include/linux/module.h:131:2: warning: 'alias' attribute ignored [-Wattributes]
     { return initfn; }     \
     ^
   include/linux/device.h:1463:1: note: in expansion of macro 'module_init'
    module_init(__driver##_init); \
    ^~~~~~~~~~~
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/spk_types.h:17:0,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/device.h:1463:29: error: expected declaration specifiers before ';' token
    module_init(__driver##_init); \
                                ^
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   include/linux/device.h:1465:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    { \
    ^
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/spk_types.h:12:0,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/module.h:137:2: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     { return exitfn; }     \
     ^
   include/linux/device.h:1468:1: note: in expansion of macro 'module_exit'
    module_exit(__driver##_exit);
    ^~~~~~~~~~~
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   include/linux/module.h:137:2: warning: 'alias' attribute ignored [-Wattributes]
     { return exitfn; }     \
     ^
   include/linux/device.h:1468:1: note: in expansion of macro 'module_exit'
    module_exit(__driver##_exit);
    ^~~~~~~~~~~
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/spk_types.h:17:0,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
   include/linux/device.h:1468:29: error: expected declaration specifiers before ';' token
    module_exit(__driver##_exit);
                                ^
   drivers/staging/speakup/spk_types.h:190:2: note: in expansion of macro 'module_driver'
     module_driver(__spk_synth, synth_add, synth_remove)
     ^~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:1: note: in expansion of macro 'module_spk_synth'
    module_spk_synth(synth_acntsa);
    ^~~~~~~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:142:31: error: expected declaration specifiers before ';' token
    module_spk_synth(synth_acntsa);
                                  ^
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: storage class specified for parameter '__UNIQUE_ID_author16'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:205:32: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
                                   ^~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:144:1: note: in expansion of macro 'MODULE_AUTHOR'
    MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
    ^~~~~~~~~~~~~
>> drivers/staging/speakup/speakup_acntsa.c:144:1: error: parameter '__UNIQUE_ID_author16' is initialized
   drivers/staging/speakup/speakup_acntsa.c:144:1: warning: '__used__' attribute ignored [-Wattributes]
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/staging/speakup/spk_types.h:6,
                    from drivers/staging/speakup/spk_priv.h:23,
                    from drivers/staging/speakup/speakup_acntsa.c:22:
>> include/linux/compiler-gcc.h:182:45: error: section attribute not allowed for '__UNIQUE_ID_author16'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:182:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^~~~~~~
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^~~~~~~~
   include/linux/compiler-gcc.h:182:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^~~~~~~
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^~~~~~~~~~~
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:205:32: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
                                   ^~~~~~~~~~~
   drivers/staging/speakup/speakup_acntsa.c:144:1: note: in expansion of macro 'MODULE_AUTHOR'
    MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
    ^~~~~~~~~~~~~
..

vim +/__UNIQUE_ID_sertype12 +182 include/linux/compiler-gcc.h

cb984d10 Joe Perches 2015-06-25  166  /* Mark functions as cold. gcc will assume any path leading to a call
cb984d10 Joe Perches 2015-06-25  167   * to them will be unlikely.  This means a lot of manual unlikely()s
cb984d10 Joe Perches 2015-06-25  168   * are unnecessary now for any paths leading to the usual suspects
cb984d10 Joe Perches 2015-06-25  169   * like BUG(), printk(), panic() etc. [but let's keep them for now for
cb984d10 Joe Perches 2015-06-25  170   * older compilers]
cb984d10 Joe Perches 2015-06-25  171   *
cb984d10 Joe Perches 2015-06-25  172   * Early snapshots of gcc 4.3 don't support this and we can't detect this
cb984d10 Joe Perches 2015-06-25  173   * in the preprocessor, but we can live with this because they're unreleased.
cb984d10 Joe Perches 2015-06-25  174   * Maketime probing would be overkill here.
cb984d10 Joe Perches 2015-06-25  175   *
cb984d10 Joe Perches 2015-06-25  176   * gcc also has a __attribute__((__hot__)) to move hot functions into
cb984d10 Joe Perches 2015-06-25  177   * a special section, but I don't see any sense in this right now in
cb984d10 Joe Perches 2015-06-25  178   * the kernel context
cb984d10 Joe Perches 2015-06-25  179   */
cb984d10 Joe Perches 2015-06-25  180  #define __cold			__attribute__((__cold__))
cb984d10 Joe Perches 2015-06-25  181  
cb984d10 Joe Perches 2015-06-25 @182  #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
cb984d10 Joe Perches 2015-06-25  183  
cb984d10 Joe Perches 2015-06-25  184  #ifndef __CHECKER__
cb984d10 Joe Perches 2015-06-25  185  # define __compiletime_warning(message) __attribute__((warning(message)))
cb984d10 Joe Perches 2015-06-25  186  # define __compiletime_error(message) __attribute__((error(message)))
cb984d10 Joe Perches 2015-06-25  187  #endif /* __CHECKER__ */
cb984d10 Joe Perches 2015-06-25  188  #endif /* GCC_VERSION >= 40300 */
cb984d10 Joe Perches 2015-06-25  189  
cb984d10 Joe Perches 2015-06-25  190  #if GCC_VERSION >= 40500

:::::: The code at line 182 was first introduced by commit
:::::: cb984d101b30eb7478d32df56a0023e4603cba7f compiler-gcc: integrate the various compiler-gcc[345].h files

:::::: TO: Joe Perches <joe@perches.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58020 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
  2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
  2017-02-04  2:41 ` kbuild test robot
@ 2017-02-04  2:53 ` kbuild test robot
  2017-02-04  4:31 ` Guenter Roeck
  2 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2017-02-04  2:53 UTC (permalink / raw)
  To: Derek Robson
  Cc: kbuild-all, w.d.hubbs, chris, kirk, samuel.thibault, gregkh,
	robsonde, devel, speakup, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 23825 bytes --]

Hi Derek,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.10-rc6 next-20170203]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/staging/speakup/speakup_acntsa.c:22:0:
   drivers/staging/speakup/spk_priv.h: In function 'synth_request_region':
>> drivers/staging/speakup/spk_priv.h:69:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
    int synth_add(struct spk_synth *in_synth);
    ^~~
>> drivers/staging/speakup/spk_priv.h:72:30: error: storage class specified for parameter 'speakup_info'
    extern struct speakup_info_t speakup_info;
                                 ^~~~~~~~~~~~
>> drivers/staging/speakup/spk_priv.h:74:21: error: storage class specified for parameter 'synth_time_vars'
    extern struct var_t synth_time_vars[];
                        ^~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/speakup.h:5:0,
                    from drivers/staging/speakup/speakup_acntsa.c:23:
>> drivers/staging/speakup/i18n.h:5:1: warning: empty declaration
    enum msg_index_t {
    ^~~~
   drivers/staging/speakup/i18n.h:221:1: warning: empty declaration
    struct msg_group_t {
    ^~~~~~
   In file included from drivers/staging/speakup/speakup_acntsa.c:23:0:
>> drivers/staging/speakup/speakup.h:66:21: error: storage class specified for parameter 'spk_special_handler'
    extern special_func spk_special_handler;
                        ^~~~~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:84:24: error: storage class specified for parameter 'spk_sel_cons'
    extern struct vc_data *spk_sel_cons;
                           ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:85:23: error: storage class specified for parameter 'spk_xs'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                          ^~~~~~
>> drivers/staging/speakup/speakup.h:85:31: error: storage class specified for parameter 'spk_ys'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                  ^~~~~~
>> drivers/staging/speakup/speakup.h:85:39: error: storage class specified for parameter 'spk_xe'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                          ^~~~~~
>> drivers/staging/speakup/speakup.h:85:47: error: storage class specified for parameter 'spk_ye'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                                  ^~~~~~
>> drivers/staging/speakup/speakup.h:87:26: error: storage class specified for parameter 'speakup_event'
    extern wait_queue_head_t speakup_event;
                             ^~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:88:24: error: storage class specified for parameter 'speakup_kobj'
    extern struct kobject *speakup_kobj;
                           ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:89:28: error: storage class specified for parameter 'speakup_task'
    extern struct task_struct *speakup_task;
                               ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:90:21: error: storage class specified for parameter 'spk_key_defaults'
    extern const u_char spk_key_defaults[];
                        ^~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:93:21: error: storage class specified for parameter 'spk_mutex'
    extern struct mutex spk_mutex;
                        ^~~~~~~~~
>> drivers/staging/speakup/speakup.h:94:25: error: storage class specified for parameter 'speakup_console'
    extern struct st_spk_t *speakup_console[];
                            ^~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:95:26: error: storage class specified for parameter 'synth'
    extern struct spk_synth *synth;
                             ^~~~~
>> drivers/staging/speakup/speakup.h:96:13: error: storage class specified for parameter 'spk_pitch_buff'
    extern char spk_pitch_buff[];
                ^~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:97:16: error: storage class specified for parameter 'spk_our_keys'
    extern u_char *spk_our_keys[];
                   ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:98:14: error: storage class specified for parameter 'spk_punc_masks'
    extern short spk_punc_masks[];
                 ^~~~~~~~~~~~~~
--
   In file included from drivers/staging/speakup/speakup_apollo.c:26:0:
   drivers/staging/speakup/spk_priv.h: In function 'synth_request_region':
>> drivers/staging/speakup/spk_priv.h:69:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
    int synth_add(struct spk_synth *in_synth);
    ^~~
>> drivers/staging/speakup/spk_priv.h:72:30: error: storage class specified for parameter 'speakup_info'
    extern struct speakup_info_t speakup_info;
                                 ^~~~~~~~~~~~
>> drivers/staging/speakup/spk_priv.h:74:21: error: storage class specified for parameter 'synth_time_vars'
    extern struct var_t synth_time_vars[];
                        ^~~~~~~~~~~~~~~
   In file included from include/linux/serial.h:13:0,
                    from drivers/staging/speakup/serialio.h:4,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/uapi/linux/serial.h:18:1: warning: empty declaration
    struct serial_struct {
    ^~~~~~
   include/uapi/linux/serial.h:83:1: warning: empty declaration
    struct serial_multiport_struct {
    ^~~~~~
   include/uapi/linux/serial.h:101:1: warning: empty declaration
    struct serial_icounter_struct {
    ^~~~~~
   include/uapi/linux/serial.h:116:1: warning: empty declaration
    struct serial_rs485 {
    ^~~~~~
   In file included from drivers/staging/speakup/serialio.h:4:0,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/serial.h:20:1: warning: empty declaration
    struct async_icount {
    ^~~~~~
   In file included from include/linux/interrupt.h:10:0,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/irqreturn.h:10:1: warning: empty declaration
    enum irqreturn {
    ^~~~
>> include/linux/irqreturn.h:16:24: error: storage class specified for parameter 'irqreturn_t'
    typedef enum irqreturn irqreturn_t;
                           ^~~~~~~~~~~
   In file included from include/linux/interrupt.h:11:0,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/irqnr.h:7:12: error: storage class specified for parameter 'nr_irqs'
    extern int nr_irqs;
               ^~~~~~~
>> include/linux/irqnr.h:8:25: error: storage class specified for parameter 'irq_to_desc'
    extern struct irq_desc *irq_to_desc(unsigned int irq);
                            ^~~~~~~~~~~
   In file included from include/linux/hardirq.h:6:0,
                    from include/linux/interrupt.h:12,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/ftrace_irq.h:9:48: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void arch_ftrace_nmi_enter(void) { }
                                                   ^
   include/linux/ftrace_irq.h:10:47: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void arch_ftrace_nmi_exit(void) { }
                                                  ^
   include/linux/ftrace_irq.h:19:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   include/linux/ftrace_irq.h:28:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   In file included from include/linux/vtime.h:4:0,
                    from include/linux/hardirq.h:7,
                    from include/linux/interrupt.h:12,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/context_tracking_state.h:7:1: warning: empty declaration
    struct context_tracking {
    ^~~~~~
>> include/linux/context_tracking_state.h:43:51: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline bool context_tracking_in_user(void) { return false; }
                                                      ^
   include/linux/context_tracking_state.h:44:50: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline bool context_tracking_active(void) { return false; }
                                                     ^
   include/linux/context_tracking_state.h:45:54: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline bool context_tracking_is_enabled(void) { return false; }
                                                         ^
   include/linux/context_tracking_state.h:46:58: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline bool context_tracking_cpu_is_enabled(void) { return false; }
                                                             ^
   In file included from include/linux/hardirq.h:7:0,
                    from include/linux/interrupt.h:12,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/vtime.h:10:1: warning: empty declaration
    struct task_struct;
    ^~~~~~
>> include/linux/vtime.h:39:55: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline bool vtime_accounting_cpu_enabled(void) { return false; }
                                                          ^
   include/linux/vtime.h:65:64: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_task_switch(struct task_struct *prev) { }
                                                                   ^
   include/linux/vtime.h:66:66: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_account_system(struct task_struct *tsk) { }
                                                                     ^
   include/linux/vtime.h:67:64: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_account_user(struct task_struct *tsk) { }
                                                                   ^
   include/linux/vtime.h:82:62: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_user_enter(struct task_struct *tsk) { }
                                                                 ^
   include/linux/vtime.h:83:61: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_user_exit(struct task_struct *tsk) { }
                                                                ^
   include/linux/vtime.h:84:63: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_guest_enter(struct task_struct *tsk) { }
                                                                  ^
   include/linux/vtime.h:85:62: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_guest_exit(struct task_struct *tsk) { }
                                                                 ^
   include/linux/vtime.h:86:70: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_init_idle(struct task_struct *tsk, int cpu) { }
                                                                         ^
   include/linux/vtime.h:97:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_account_irq_enter(struct task_struct *tsk) { }
                                                                        ^
   include/linux/vtime.h:98:68: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void vtime_account_irq_exit(struct task_struct *tsk) { }
                                                                       ^
   include/linux/vtime.h:105:65: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    static inline void irqtime_account_irq(struct task_struct *tsk) { }
                                                                    ^
   include/linux/vtime.h:109:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   include/linux/vtime.h:115:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   In file included from include/linux/irq.h:18:0,
                    from arch/x86/include/asm/hardirq.h:5,
                    from include/linux/hardirq.h:8,
                    from include/linux/interrupt.h:12,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> include/linux/irqhandler.h:9:1: warning: empty declaration
    struct irq_desc;
    ^~~~~~
   include/linux/irqhandler.h:10:1: warning: empty declaration
    struct irq_data;
    ^~~~~~
>> include/linux/irqhandler.h:11:16: error: storage class specified for parameter 'irq_flow_handler_t'
    typedef void (*irq_flow_handler_t)(struct irq_desc *desc);
                   ^~~~~~~~~~~~~~~~~~
>> include/linux/irqhandler.h:12:16: error: storage class specified for parameter 'irq_preflow_handler_t'
    typedef void (*irq_preflow_handler_t)(struct irq_data *data);
                   ^~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/irq.h:26:0,
                    from arch/x86/include/asm/hardirq.h:5,
                    from include/linux/hardirq.h:8,
                    from include/linux/interrupt.h:12,
                    from include/linux/serial_core.h:25,
                    from drivers/staging/speakup/serialio.h:9,
                    from drivers/staging/speakup/speakup_apollo.c:27:
>> arch/x86/include/asm/irq.h:14:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
>> arch/x86/include/asm/irq.h:26:1: warning: empty declaration
    struct irq_desc;
    ^~~~~~
>> arch/x86/include/asm/irq.h:30:12: error: storage class specified for parameter 'check_irq_vectors_for_cpu_disable'
    extern int check_irq_vectors_for_cpu_disable(void);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from drivers/staging/speakup/speakup_audptr.c:21:0:
   drivers/staging/speakup/spk_priv.h: In function 'synth_request_region':
>> drivers/staging/speakup/spk_priv.h:69:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
    int synth_add(struct spk_synth *in_synth);
    ^~~
>> drivers/staging/speakup/spk_priv.h:72:30: error: storage class specified for parameter 'speakup_info'
    extern struct speakup_info_t speakup_info;
                                 ^~~~~~~~~~~~
>> drivers/staging/speakup/spk_priv.h:74:21: error: storage class specified for parameter 'synth_time_vars'
    extern struct var_t synth_time_vars[];
                        ^~~~~~~~~~~~~~~
   In file included from drivers/staging/speakup/speakup.h:5:0,
                    from drivers/staging/speakup/speakup_audptr.c:22:
>> drivers/staging/speakup/i18n.h:5:1: warning: empty declaration
    enum msg_index_t {
    ^~~~
   drivers/staging/speakup/i18n.h:221:1: warning: empty declaration
    struct msg_group_t {
    ^~~~~~
   In file included from drivers/staging/speakup/speakup_audptr.c:22:0:
>> drivers/staging/speakup/speakup.h:66:21: error: storage class specified for parameter 'spk_special_handler'
    extern special_func spk_special_handler;
                        ^~~~~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:84:24: error: storage class specified for parameter 'spk_sel_cons'
    extern struct vc_data *spk_sel_cons;
                           ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:85:23: error: storage class specified for parameter 'spk_xs'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                          ^~~~~~
>> drivers/staging/speakup/speakup.h:85:31: error: storage class specified for parameter 'spk_ys'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                  ^~~~~~
>> drivers/staging/speakup/speakup.h:85:39: error: storage class specified for parameter 'spk_xe'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                          ^~~~~~
>> drivers/staging/speakup/speakup.h:85:47: error: storage class specified for parameter 'spk_ye'
    extern unsigned short spk_xs, spk_ys, spk_xe, spk_ye; /* our region points */
                                                  ^~~~~~
>> drivers/staging/speakup/speakup.h:87:26: error: storage class specified for parameter 'speakup_event'
    extern wait_queue_head_t speakup_event;
                             ^~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:88:24: error: storage class specified for parameter 'speakup_kobj'
    extern struct kobject *speakup_kobj;
                           ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:89:28: error: storage class specified for parameter 'speakup_task'
    extern struct task_struct *speakup_task;
                               ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:90:21: error: storage class specified for parameter 'spk_key_defaults'
    extern const u_char spk_key_defaults[];
                        ^~~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:93:21: error: storage class specified for parameter 'spk_mutex'
    extern struct mutex spk_mutex;
                        ^~~~~~~~~
>> drivers/staging/speakup/speakup.h:94:25: error: storage class specified for parameter 'speakup_console'
    extern struct st_spk_t *speakup_console[];
                            ^~~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:95:26: error: storage class specified for parameter 'synth'
    extern struct spk_synth *synth;
                             ^~~~~
>> drivers/staging/speakup/speakup.h:96:13: error: storage class specified for parameter 'spk_pitch_buff'
    extern char spk_pitch_buff[];
                ^~~~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:97:16: error: storage class specified for parameter 'spk_our_keys'
    extern u_char *spk_our_keys[];
                   ^~~~~~~~~~~~
>> drivers/staging/speakup/speakup.h:98:14: error: storage class specified for parameter 'spk_punc_masks'
    extern short spk_punc_masks[];
                 ^~~~~~~~~~~~~~
..

vim +69 drivers/staging/speakup/spk_priv.h

c6e3fd22 William Hubbs 2010-10-07  24  #include "spk_priv_keyinfo.h"
c6e3fd22 William Hubbs 2010-10-07  25  
c6e3fd22 William Hubbs 2010-10-07  26  #ifndef pr_warn
c6e3fd22 William Hubbs 2010-10-07  27  #define pr_warn(fmt, arg...) printk(KERN_WARNING fmt, ##arg)
c6e3fd22 William Hubbs 2010-10-07  28  #endif
c6e3fd22 William Hubbs 2010-10-07  29  
c6e3fd22 William Hubbs 2010-10-07 @30  #define V_LAST_VAR { MAXVARS }
c6e3fd22 William Hubbs 2010-10-07  31  #define SPACE 0x20
c6e3fd22 William Hubbs 2010-10-07  32  #define SYNTH_CHECK 20030716 /* today's date ought to do for check value */
c6e3fd22 William Hubbs 2010-10-07  33  /* synth flags, for odd synths */
c6e3fd22 William Hubbs 2010-10-07  34  #define SF_DEC 1 /* to fiddle puncs in alpha strings so it doesn't spell */
c6e3fd22 William Hubbs 2010-10-07  35  #ifdef MODULE
c6e3fd22 William Hubbs 2010-10-07  36  #define SYNTH_START 1
c6e3fd22 William Hubbs 2010-10-07  37  #else
c6e3fd22 William Hubbs 2010-10-07  38  #define SYNTH_START 0
c6e3fd22 William Hubbs 2010-10-07  39  #endif
c6e3fd22 William Hubbs 2010-10-07  40  
c6e3fd22 William Hubbs 2010-10-07  41  #define KT_SPKUP 15
c6e3fd22 William Hubbs 2010-10-07  42  
13d932f7 Katie Dunne   2015-02-26  43  const struct old_serial_port *spk_serial_init(int index);
13d932f7 Katie Dunne   2015-02-26  44  void spk_stop_serial_interrupt(void);
13d932f7 Katie Dunne   2015-02-26  45  int spk_wait_for_xmitr(void);
13d932f7 Katie Dunne   2015-02-26  46  unsigned char spk_serial_in(void);
13d932f7 Katie Dunne   2015-02-26  47  unsigned char spk_serial_in_nowait(void);
13d932f7 Katie Dunne   2015-02-26  48  int spk_serial_out(const char ch);
13d932f7 Katie Dunne   2015-02-26  49  void spk_serial_release(void);
c6e3fd22 William Hubbs 2010-10-07  50  
13d932f7 Katie Dunne   2015-02-26  51  char synth_buffer_getc(void);
13d932f7 Katie Dunne   2015-02-26  52  char synth_buffer_peek(void);
13d932f7 Katie Dunne   2015-02-26  53  int synth_buffer_empty(void);
13d932f7 Katie Dunne   2015-02-26  54  struct var_t *spk_get_var(enum var_id_t var_id);
13d932f7 Katie Dunne   2015-02-26  55  ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
c6e3fd22 William Hubbs 2010-10-07  56  		     char *buf);
13d932f7 Katie Dunne   2015-02-26  57  ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
c6e3fd22 William Hubbs 2010-10-07  58  		      const char *buf, size_t count);
c6e3fd22 William Hubbs 2010-10-07  59  
13d932f7 Katie Dunne   2015-02-26  60  int spk_serial_synth_probe(struct spk_synth *synth);
13d932f7 Katie Dunne   2015-02-26  61  const char *spk_synth_immediate(struct spk_synth *synth, const char *buff);
13d932f7 Katie Dunne   2015-02-26  62  void spk_do_catch_up(struct spk_synth *synth);
13d932f7 Katie Dunne   2015-02-26  63  void spk_synth_flush(struct spk_synth *synth);
13d932f7 Katie Dunne   2015-02-26  64  int spk_synth_is_alive_nop(struct spk_synth *synth);
13d932f7 Katie Dunne   2015-02-26  65  int spk_synth_is_alive_restart(struct spk_synth *synth);
13d932f7 Katie Dunne   2015-02-26  66  void synth_printf(const char *buf, ...);
68db8938 Derek Robson  2017-02-04 @67  int synth_request_region(unsigned long start, unsigned long n)
68db8938 Derek Robson  2017-02-04  68  int synth_release_region(unsigned long start, unsigned long n)
13d932f7 Katie Dunne   2015-02-26 @69  int synth_add(struct spk_synth *in_synth);
13d932f7 Katie Dunne   2015-02-26  70  void synth_remove(struct spk_synth *in_synth);
c6e3fd22 William Hubbs 2010-10-07  71  
c6e3fd22 William Hubbs 2010-10-07 @72  extern struct speakup_info_t speakup_info;
c6e3fd22 William Hubbs 2010-10-07  73  
c6e3fd22 William Hubbs 2010-10-07 @74  extern struct var_t synth_time_vars[];
c6e3fd22 William Hubbs 2010-10-07  75  
c6e3fd22 William Hubbs 2010-10-07  76  #endif

:::::: The code at line 69 was first introduced by commit
:::::: 13d932f79cea6b59b9a18a54c2e776d88799654d Staging: speakup: Remove 'extern' keywords from .h prototypes

:::::: TO: Katie Dunne <kdunne@mail.ccsf.edu>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38065 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
  2017-02-04  2:41 ` kbuild test robot
@ 2017-02-04  3:31   ` Derek Robson
  2017-02-04  4:21     ` Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Derek Robson @ 2017-02-04  3:31 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, w.d.hubbs, chris, kirk, samuel.thibault, gregkh,
	devel, speakup, linux-kernel

On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> Hi Derek,
> 
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.10-rc6 next-20170203]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All error/warnings (new ones prefixed by >>):
> 
>     #define param_check_int(name, p) __param_check(name, p, int)
>                                      ^~~~~~~~~~~~~
>    include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
>      param_check_##type(name, &(value));       \
>      ^~~~~~~~~~~~
>    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
>     module_param_named(ser, synth_acntsa.ser, int, 0444);
>     ^~~~~~~~~~~~~~~~~~
>    include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
>      param_check_##type(name, &(value));       \
>                                        ^
>    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
>     module_param_named(ser, synth_acntsa.ser, int, 0444);
>     ^~~~~~~~~~~~~~~~~~
>    include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
>      static const char __param_str_##name[] = prefix #name;  \

Can anyone tell me what I did wrong?
I don't think it was my patch that broke the build.

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix
  2017-02-04  3:31   ` Derek Robson
@ 2017-02-04  4:21     ` Joe Perches
  0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2017-02-04  4:21 UTC (permalink / raw)
  To: Derek Robson, kbuild test robot
  Cc: kbuild-all, w.d.hubbs, chris, kirk, samuel.thibault, gregkh,
	devel, speakup, linux-kernel

On Sat, 2017-02-04 at 16:31 +1300, Derek Robson wrote:
> On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> > Hi Derek,
> > 
> > [auto build test ERROR on staging/staging-testing]
> > [also build test ERROR on v4.10-rc6 next-20170203]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > All error/warnings (new ones prefixed by >>):
> > 
> >     #define param_check_int(name, p) __param_check(name, p, int)
> >                                      ^~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
> >      param_check_##type(name, &(value));       \
> >      ^~~~~~~~~~~~
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
> >      param_check_##type(name, &(value));       \
> >                                        ^
> >    drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> >     module_param_named(ser, synth_acntsa.ser, int, 0444);
> >     ^~~~~~~~~~~~~~~~~~
> >    include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
> >      static const char __param_str_##name[] = prefix #name;  \
> 
> Can anyone tell me what I did wrong?

You removed semicolons from the function prototypes.

-int synth_request_region(u_long, u_long);
-int synth_release_region(u_long, u_long);
+int synth_request_region(unsigned long start, unsigned long n)
+int synth_release_region(unsigned long start, unsigned long n)

> I don't think it was my patch that broke the build.

You should make sure you build test a patch
before sending it on to the list.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Drivers: staging: speakup: spk_priv.h - style fix
  2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
  2017-02-04  2:41 ` kbuild test robot
  2017-02-04  2:53 ` kbuild test robot
@ 2017-02-04  4:31 ` Guenter Roeck
  2 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2017-02-04  4:31 UTC (permalink / raw)
  To: Derek Robson
  Cc: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, speakup, devel,
	linux-kernel

On Sat, Feb 04, 2017 at 12:56:41PM +1300, Derek Robson wrote:
> Changed function definition argument to have identifier name.
> found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/speakup/spk_priv.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/speakup/spk_priv.h b/drivers/staging/speakup/spk_priv.h
> index 98c4b6f0344a..1952d7887b3b 100644
> --- a/drivers/staging/speakup/spk_priv.h
> +++ b/drivers/staging/speakup/spk_priv.h
> @@ -64,8 +64,8 @@ void spk_synth_flush(struct spk_synth *synth);
>  int spk_synth_is_alive_nop(struct spk_synth *synth);
>  int spk_synth_is_alive_restart(struct spk_synth *synth);
>  void synth_printf(const char *buf, ...);
> -int synth_request_region(u_long, u_long);
> -int synth_release_region(u_long, u_long);
> +int synth_request_region(unsigned long start, unsigned long n)
> +int synth_release_region(unsigned long start, unsigned long n)

Hmmm .. you didn't compile test your code, did you ? 

You asked why 0day reports an error. If you compile this code,
I am quite sure that you are going to see the same errors.

Guenter

>  int synth_add(struct spk_synth *in_synth);
>  void synth_remove(struct spk_synth *in_synth);
>  

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-02-04  4:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 23:56 [PATCH] Drivers: staging: speakup: spk_priv.h - style fix Derek Robson
2017-02-04  2:41 ` kbuild test robot
2017-02-04  3:31   ` Derek Robson
2017-02-04  4:21     ` Joe Perches
2017-02-04  2:53 ` kbuild test robot
2017-02-04  4:31 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.