From: Matt Mullins <mmullins@mmlx.us>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: Andy Lutomirski <luto@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rusty Russell <rusty@rustcorp.com.au>, Jens Axboe <axboe@fb.com>,
Matt Mullins <mmullins@mmlx.us>, Xishi Qiu <qiuxishi@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()
Date: Fri, 3 Feb 2017 20:34:16 -0800 [thread overview]
Message-ID: <20170204043416.GA7458@hydra.tuxags.com> (raw)
In-Reply-To: <b0545f55-3b3c-35af-c9f6-bc63cf169d2d@huawei.com>
On Sat, Feb 04, 2017 at 11:47:38AM +0800, Yisheng Xie wrote:
> On 2016/10/18 1:06, Andy Lutomirski wrote:
> > hw_random carefully avoids using a stack buffer except in
> > add_early_randomness(). This causes a crash in virtio_rng if
> > CONFIG_VMAP_STACK=y.
> I try to understand this patch, but I do not know why it will cause
> a crash in virtio_rng with CONFIG_VMAP_STACK=y?
> Could you please give me more info. about it.
My original report was
https://lkml.kernel.org/r/20161016002151.GA18235@hydra.tuxags.com.
The virtio ring APIs use scatterlists to keep track of the buffers, and
scatterlist requires addresses to be in the kernel direct-mapped address range.
This is not the case for vmalloc()ed addresses, such as the original on-stack
"bytes" array when VMAP_STACK=y.
next prev parent reply other threads:[~2017-02-04 4:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:06 [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski
2016-10-16 21:19 ` [PATCH " Matt Mullins
2016-10-17 17:17 ` [PATCH resend " Stephan Mueller
2016-10-17 17:30 ` Andy Lutomirski
2016-10-17 18:36 ` Stephan Mueller
2016-10-17 21:03 ` Andy Lutomirski
2016-10-17 21:14 ` Stephan Mueller
2016-10-19 3:50 ` Herbert Xu
2017-02-04 3:47 ` Yisheng Xie
2017-02-04 4:34 ` Matt Mullins [this message]
2017-02-04 10:32 ` Yisheng Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170204043416.GA7458@hydra.tuxags.com \
--to=mmullins@mmlx.us \
--cc=axboe@fb.com \
--cc=guohanjun@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mpm@selenic.com \
--cc=qiuxishi@huawei.com \
--cc=rusty@rustcorp.com.au \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.