On Fri, Feb 03, 2017 at 01:56:01PM -0800, Dmitry Torokhov wrote: > - return NULL; > + return r ? r : ERR_PTR(-ENODEV); > } Please write normal conditional statements to keep the code legible.