From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbdBEI7u (ORCPT ); Sun, 5 Feb 2017 03:59:50 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:34897 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbdBEI7s (ORCPT ); Sun, 5 Feb 2017 03:59:48 -0500 Date: Sun, 5 Feb 2017 00:59:47 -0800 From: Christoph Hellwig To: Jaegeuk Kim Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, axboe@kernel.dk Subject: Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously Message-ID: <20170205085947.GA25319@infradead.org> References: <20170112224407.54026-1-jaegeuk@kernel.org> <20170112224407.54026-5-jaegeuk@kernel.org> <20170113080159.GB31777@infradead.org> <20170113191211.GB1301@jaegeuk.local> <20170116173220.GA2199@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170116173220.GA2199@infradead.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 09:32:20AM -0800, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 11:12:11AM -0800, Jaegeuk Kim wrote: > > Previously, I've done to issue discard bios asynchronously. But the problem that > > I've got is that was not enough. When testing nvme SSD with noop IO scheduler, > > submit_bio() was blocked at every 8 async discard bios, resulting in very slow > > checkpoint process which blocks most of other FS operations. > > Where does it block? Are you running out of request? What driver is > this on top of? Ping? I'm currently spending a lot of effort on fs and block dÑ–scard code, and I'd like to make sure we get common infrastructure instead of local hacks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 5/6] f2fs: add a kernel thread to issue discard commands asynchronously Date: Sun, 5 Feb 2017 00:59:47 -0800 Message-ID: <20170205085947.GA25319@infradead.org> References: <20170112224407.54026-1-jaegeuk@kernel.org> <20170112224407.54026-5-jaegeuk@kernel.org> <20170113080159.GB31777@infradead.org> <20170113191211.GB1301@jaegeuk.local> <20170116173220.GA2199@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1caIfv-0008OX-Jv for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Feb 2017 08:59:59 +0000 Received: from bombadil.infradead.org ([65.50.211.133]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1caIfu-0005IJ-HP for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Feb 2017 08:59:59 +0000 Content-Disposition: inline In-Reply-To: <20170116173220.GA2199@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net T24gTW9uLCBKYW4gMTYsIDIwMTcgYXQgMDk6MzI6MjBBTSAtMDgwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gT24gRnJpLCBKYW4gMTMsIDIwMTcgYXQgMTE6MTI6MTFBTSAtMDgwMCwgSmFl Z2V1ayBLaW0gd3JvdGU6Cj4gPiBQcmV2aW91c2x5LCBJJ3ZlIGRvbmUgdG8gaXNzdWUgZGlzY2Fy ZCBiaW9zIGFzeW5jaHJvbm91c2x5LiBCdXQgdGhlIHByb2JsZW0gdGhhdAo+ID4gSSd2ZSBnb3Qg aXMgdGhhdCB3YXMgbm90IGVub3VnaC4gV2hlbiB0ZXN0aW5nIG52bWUgU1NEIHdpdGggbm9vcCBJ TyBzY2hlZHVsZXIsCj4gPiBzdWJtaXRfYmlvKCkgd2FzIGJsb2NrZWQgYXQgZXZlcnkgOCBhc3lu YyBkaXNjYXJkIGJpb3MsIHJlc3VsdGluZyBpbiB2ZXJ5IHNsb3cKPiA+IGNoZWNrcG9pbnQgcHJv Y2VzcyB3aGljaCBibG9ja3MgbW9zdCBvZiBvdGhlciBGUyBvcGVyYXRpb25zLgo+IAo+IFdoZXJl IGRvZXMgaXQgYmxvY2s/ICBBcmUgeW91IHJ1bm5pbmcgb3V0IG9mIHJlcXVlc3Q/ICBXaGF0IGRy aXZlciBpcwo+IHRoaXMgb24gdG9wIG9mPwoKUGluZz8gIEknbSBjdXJyZW50bHkgc3BlbmRpbmcg YSBsb3Qgb2YgZWZmb3J0IG9uIGZzIGFuZCBibG9jayBk0ZZzY2FyZApjb2RlLCBhbmQgSSdkIGxp a2UgdG8gbWFrZSBzdXJlIHdlIGdldCBjb21tb24gaW5mcmFzdHJ1Y3R1cmUgaW5zdGVhZApvZiBs b2NhbCBoYWNrcy4KCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpDaGVjayBvdXQgdGhlIHZpYnJhbnQg dGVjaCBjb21tdW5pdHkgb24gb25lIG9mIHRoZSB3b3JsZCdzIG1vc3QKZW5nYWdpbmcgdGVjaCBz aXRlcywgU2xhc2hEb3Qub3JnISBodHRwOi8vc2RtLmxpbmsvc2xhc2hkb3QKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWls aW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9s aXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo=