From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbdBFNgm (ORCPT ); Mon, 6 Feb 2017 08:36:42 -0500 Received: from mail-by2nam01on0077.outbound.protection.outlook.com ([104.47.34.77]:13920 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752233AbdBFNgh (ORCPT ); Mon, 6 Feb 2017 08:36:37 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Mon, 6 Feb 2017 14:36:11 +0100 From: Robert Richter To: Ard Biesheuvel CC: , , , , , , , , Subject: Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA Message-ID: <20170206133611.GL16822@rric.localdomain> References: <1481706707-6211-1-git-send-email-ard.biesheuvel@linaro.org> <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.83.223] X-ClientProxiedBy: AM4PR02CA0014.eurprd02.prod.outlook.com (10.165.239.152) To BY2PR07MB2341.namprd07.prod.outlook.com (10.166.114.143) X-MS-Office365-Filtering-Correlation-Id: 573bbdf4-6060-48ef-8a3c-08d44e9524ff X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR07MB2341; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2341;3:KuF1lJGuCST1Cj18CeF1eiNkzKfvCj9mcuNhQ7f6CxwJy5oC5SOK+Vk4ja3IU5urVNLFt57OrjfVOutPDvwlBeIUeIVHhEVzsGps09jzFpHQ2C38eqiPuhS94+29VvA5XI/cBHbXzQsSrqZU04VSkmOhS780NIiHDA4rVvRK07EthOpyjcD1IQGeDWMOVOs4JIhOilab7rN5lR4CJjR2oR7JSFYtaJDmMk0RqyBSSHC+Sdh+APd7ebhKovbTvKrqxoGOPK0rgPoBRRKjTmHaTQ==;25:xmaYZu13uAytIXWLDEbD/kFVBeP/fJzJb3grFHhGhyjcdYMX2op/rpVOdaEgkNBOyYc2jgaRF3J3JpbAtAaVAajTd6QtBMxEtjryLhSjQVmLZmGc8R50mABG9sqV8wyyCvTz5PRU98FL8sCV6tmwGmshTAb3bElC2FU3HKs/pcwP+bdYdqJ3iskVqki5ejYQ5aExYRPk8tXRT/vINanqt73MzqpvX2q1CLRoUbsXwXUdFeZkHNUsp+ZvaiCX+n4fjh5aNSlKP+yBmblbCGHa6PPY7x2FZOCmy2hT8wDJo5vPp4NwYyWozklmkUBeV4gfTNAq0s3vuXwvj/dOSzEvYS8BBrpPPNVI54RN1SvnwdODZcw2bdm6Inm0lYZbkX4EgBsSAGAqq1WFnPsNkXGIyUeIz41FNHgWzoCi5ZKxo+v7WFowtuk9S5k/sprpFKvMv0YEgvwSSTMZOXsvIAAM0w== X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2341;31:VaKOjfQ/cwZ8aOmXsTimjabiS3OA0nvSuSYsBpIvG836SmnHi1OClzdTqeBIOrx0fqR8AKrWCL5nQA1rTuMKj846GozYD0O0yz60kNWh8jNXMJX+iO/E6RHieUtj6S0lXBYdw4ZuXH4mTBcRE3R5Leo0OUDTPIvdGOn9aoJ029Uur9hjCClZRKBVlFzmFh+56FULU/9N3C5r9d2S7NVptdAbXA1LnYLC4s/jnMYHJdIDriLSd+pkJ7GpiOdrrRN2I+oG/SH119bFc6I75+nAXA==;20:MpGVKeiOEaDjd0qpFVXiAyiX3z6BLkn/vR5NNol9K2quP4siwyQd2SEyFiCF2poT2BozGOc06GM2r9KHa1xjA4TEImZWKfUAc6QNTEn4e8AifLXEWu+Hp6kdy/CnvUtV7Q6yyxAcm20YycKAJ/aTiAs+fXmZWPhkoJo3afTxTVSnjptjNqw+qb2w8moUBr5JvIGbsInn0pL6+VFhfXCHrMvz8owZMrDCO5/pgX6NRleAkINb0cT/fed7IWD0VitbC07exrfobiVMPymp+arKwD8IcAF4tMCgDksiuE0gbVsuQJ0EYSGZYPKBmbPkvom6yFuKKJBdvf6FMh3ExC3+HbVM0rpsc5vc3G07sBu6s/K4t8JNo1Oc6CE7SQrhwcuFVHeJ7goJgA1gPcMZBuO9+m7clk7IzQtUpO48rhiwibE8irnhNGHG9HrtoD0cerGEkODrdG+E0oPfMyBfzlMOClecc9xc9Ex4qXj5QuhhFgmyztdG5TMxay89jIyWt9AM X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(20170203043)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558025)(6072148);SRVR:BY2PR07MB2341;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB2341; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2341;4:X1NeHNN59CnFPiJqJfMLFwSJyFOWx13W5vV9w10U5WupBxOXKPDnaxUyqXJmYiyfwGyEay3rvqjVKOVLTREbPwX2mgORyojsJdyH8mH6+1g7oT+eyC+4Hkvhx33VUYZDa5xl85IqJj6gzIflNZtjzxQu7KcJ3VDNnVj/4kQ/3uU5JZGLMA/BrWvxqjyWihGGlpQg6Uur2g4YLefrzfF/jSm6fBcE3y1CGM/Fcl6gRIic407Bl+Vj2U6gfI2wMV9toE6qX1q82WkE3ZrHaEPkeEGV42H1ibAEv3CqQ/S9lJCvpMu9wMY12qAqKqADy1Is9zvQOw/mJ8+F04PKNClVykeRzjgjlqoDMxURh1sq/XzEVoZ1A1jWWCV6owwjNOh3Y2XEB5hkgXuRzEOdjal8GsZ6x3xiDP1A61zpp+2rEB0HZejUHnbhncTIm/3EMHBVt3KFU8JeATm7A2sQKU4b+Np+HXHwp4WWS20MDLQPp6PHGko3C2xmJz7SIU4mQM6mTrAne5rFnk9/t34oKuOv/r+4OOJqz0MvgH5uBfoNLeoVZTMWdAj3lfAJwX3ZUOB4jZqswELWPxzjuKAWLj4G+Fe57AOaMYN8zfLjfGhMMLeFz69ZK9GzQLZaTtqXSBOe1538aJwQIxSKYJ83a1O+Ng== X-Forefront-PRVS: 0210479ED8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(189002)(199003)(97736004)(92566002)(229853002)(2906002)(42186005)(66066001)(6506006)(9686003)(106356001)(1076002)(8676002)(54906002)(50466002)(55016002)(53546003)(83506001)(6246003)(86362001)(6666003)(4001350100001)(6116002)(3846002)(189998001)(68736007)(97756001)(33656002)(47776003)(7736002)(305945005)(4326007)(25786008)(2950100002)(6916009)(5660300001)(38730400001)(105586002)(81166006)(81156014)(7416002)(53936002)(76176999)(54356999)(50986999)(23726003)(46406003)(101416001)(110136003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB2341;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB2341;23:BGJCsaz8R7hCD7MXnh44H8pYb8BG0ImBuCQbw/o3k?= =?us-ascii?Q?yZkWb4H2CBH6aqscMbnbooYSyTwLpey6scfSo6NZtS7ZaLAdsOhwLoH4qpF/?= =?us-ascii?Q?UKcERtV08rmgh8uZ6eAq3tWlhMClAeW8ymBo0Soc8YWvsUxC3Nrf5+l9LQ93?= =?us-ascii?Q?Xwm7skhF+gUfY+ZsbJipKgp3MpF+u6+T/yvbw85bnIgEWWc5+3IUkviKQxLX?= =?us-ascii?Q?6MA8HghIbXxEjg2gclLT2oq/SZGR5WIaH02lwKaOXq3dBeaMXkxEfxuXACAu?= =?us-ascii?Q?LxVrE6lAnzKzB+1V/XTgp0sJzQKoCulUreCdiigBeWhymx/nA1H5D8d8MrCq?= =?us-ascii?Q?VaShhdKmWRI4MEsTvNnjv/ops0IChTX310BLQofemSoNF4bNteqseDy2oGYH?= =?us-ascii?Q?pwiIWTMnqhZ+4tvsS+32rEsd1CPX/h8x9XLp5nLfdf5aATzJ+vR3x4FVKkfv?= =?us-ascii?Q?fX4CAqKy/fwAzQLc9OOa+yP5OSXe1v//JGZxKURtQQNFFSOzA+pSCy0phAL4?= =?us-ascii?Q?URXroXSQs/W1lIXFOg9Zm95Y5SLlDED5MnGToiRh0714qq7R+xAhMOWhaKab?= =?us-ascii?Q?8gytmcGhqrOlmmN+lNfYRv05rxSIXgrobBIjhhb5IALiMjcZe8U5ws2LsPN5?= =?us-ascii?Q?SBUyb5CXAvBEy4h0hFt7SC8/2nHJ2inIOLD+Hq4CHCNCyYu397o6AXNl806D?= =?us-ascii?Q?sFWUtmiI/jFAaXsIQgpRDcKDvHI+1BRoUL8BxPxfns8YHbnqgxSqku2Bjv6w?= =?us-ascii?Q?laFfxvqX2Y5YHsWsEEJxE6SOfI0iVNuAut0ygTjW3KqsBK8TQpdqQcZVF1TW?= =?us-ascii?Q?LDxYZlPxKaitXjJIvG3X79SVCDQ08aIfHkHPEg9jeI5g316fXcuZVrV4u1j1?= =?us-ascii?Q?bF5ZmsWsjY9642crLgi02Pl+CF0UcxsexLoir1048nz4/16xpnXE3fhyPAa6?= =?us-ascii?Q?63N+Mf1OBThQ1eQGk8wz97sBmiz9wBArzj5bx79aBh8USuaqcfVeXA/iAHys?= =?us-ascii?Q?yr+yuxb5t7Ei0joZQheftHVGKoKNWHr/BWysthGAub9yCRezkI0vvyWQnq9q?= =?us-ascii?Q?2vetD+K27hwgkc7S7tTgJc4OWtrf+WxyROFkhteXGRFWLgCYUHEA6E8yIx9L?= =?us-ascii?Q?oAEW1XQ19pi1P2tLBTnAMecXy+9zSqC+7fDTAxhCHddtawyCK7LtmLYLkpPq?= =?us-ascii?Q?4VKj8A8TFWDCJT/I3vHppki1WLtIgwXWAI2MvJW4UVTY20lfiOO82zjP0cWt?= =?us-ascii?Q?FR+GHsStqa6LJVpEVEfOslZ186ABd0mqo0FEzJHZEXXR7VvTAtVe/f4kwvxF?= =?us-ascii?Q?i8FvNvzDoWQu5IE2q+Z3L0=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2341;6:MfawBict6RoJb+ZmlaJ8D4Kqu05qGfTAHy6a+MOYOlJbdIkfnXATeSPxLjwEh8kHYc7j5VxX1XKf1J3vp0yN2gixRZkMp5Ug+12CJ5OBxWF4MCrnGXNO9aOlb4I/5iS30pbRb9NZ6EkRXQEfpIXQH5pnRp56KcRJh3yDsFyrlgDeTQog8IxgRqK4dxtwLTConlhLPCGMZ2Fj4LEpz7TLD+NSw5PvzqpvAGAf0AbKUpxvUAy4XrKb7hG1S1tHAV58sgUNZhSfOLhAL70pqp3QniyYXCWl/y6ZJ/MRkEDkFEGUYioH99fJvbSA5s1G73t6z61hLiYZYy8uCXJHzAQOm11i83nKsICOaZ5WzaBaHYeaqSY/VohrBLK2wKJpLHHxuFYrlCZgfOhK2JfSWs2ZLw==;5:IMcZ30l8s9xCJKtb0CnFrm/rTZd7XKMqTJIKq4d7Htd9nlbGLT2chvq6KGPoNTgjwNZ7FvPw6XsIIOXybMV86RJvY6g+dsZRKUZ838YmpGN+xKpXoJ4iHV38LRyYiM5/s7JMYWRxHMJiLCpLpPftPeAPxL3G1E+1lMJFQMK0bGk=;24:dIDzgDTGeHtfaETXs9mmBd7a6O7IVyBMZJRDfPJP0wwNaWjWpT1qTiw6uEHlUeGKKER6xABgcjonAxDBLK5QuastqrxcFP9m6k4iT3Y4Dow= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2341;7:LcSkwoRA6qVcFZW0PCglZ0ifLkTzjhuuU+oeQ3bCGnrxQt11EwX+bsc0fnriXa4Arc+sDToEg9G01QLlVyD5/cUYuNDASsPxzQBLyu2jpe5TrfCXzj5IjJ5XnrWq+JeYQ5AlC0Qn9CDpnRV2112ifouEc3s9eUg6cjcfO/MlUwjivK9EodtsCbIZ3b9B1MWPX4SdtK/TvNvKnfWzBnTagu3SBnYwp3eYjwnn7Tm3rTKqCE3emgxFtr4qvTgOcXbuksH6OVtwgIku56e6XwmFS0Sykjo7OtGWPgvR7UPM/Vy1DIDJBKo3hzdPK6fSZx01v/z8VuuoCxbZh1EHMq72fsXH9PuBkrDsTZvwnaIMYvwU9UkU9DiHPiMot0R8JXd3vlXgRsU5hmupSm+XDZz5Oo5sWdpVzjHnZvn8ChdpDp+fklMF24hN280jw2+pYBFRpwFuTorGLaZ0+MbWkuAWGNmCPXBmRuLMeiEtJDLR2weXVYQeaHThgy501tL7yutGmMz7ByL/puD2FTiY8OyFzg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2017 13:36:22.2615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB2341 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.12.16 09:11:47, Ard Biesheuvel wrote: > The NUMA code may get confused by the presence of NOMAP regions within > zones, resulting in spurious BUG() checks where the node id deviates > from the containing zone's node id. > > Since the kernel has no business reasoning about node ids of pages it > does not own in the first place, enable CONFIG_HOLES_IN_ZONE to ensure > that such pages are disregarded. > > Signed-off-by: Ard Biesheuvel I would rather see a solution other than making pfn_valid checks more fine grained, but this patch also fixes the issue. So: Acked-by: Robert Richter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by kanga.kvack.org (Postfix) with ESMTP id 2E7D06B0033 for ; Mon, 6 Feb 2017 08:36:28 -0500 (EST) Received: by mail-it0-f70.google.com with SMTP id h10so79218613ith.2 for ; Mon, 06 Feb 2017 05:36:28 -0800 (PST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0050.outbound.protection.outlook.com. [104.47.41.50]) by mx.google.com with ESMTPS id f13si9164814iod.99.2017.02.06.05.36.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Feb 2017 05:36:27 -0800 (PST) Date: Mon, 6 Feb 2017 14:36:11 +0100 From: Robert Richter Subject: Re: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA Message-ID: <20170206133611.GL16822@rric.localdomain> References: <1481706707-6211-1-git-send-email-ard.biesheuvel@linaro.org> <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> Sender: owner-linux-mm@kvack.org List-ID: To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, catalin.marinas@arm.com, akpm@linux-foundation.org, hanjun.guo@linaro.org, xieyisheng1@huawei.com, james.morse@arm.com On 14.12.16 09:11:47, Ard Biesheuvel wrote: > The NUMA code may get confused by the presence of NOMAP regions within > zones, resulting in spurious BUG() checks where the node id deviates > from the containing zone's node id. > > Since the kernel has no business reasoning about node ids of pages it > does not own in the first place, enable CONFIG_HOLES_IN_ZONE to ensure > that such pages are disregarded. > > Signed-off-by: Ard Biesheuvel I would rather see a solution other than making pfn_valid checks more fine grained, but this patch also fixes the issue. So: Acked-by: Robert Richter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.richter@cavium.com (Robert Richter) Date: Mon, 6 Feb 2017 14:36:11 +0100 Subject: [PATCH 2/2] arm64: mm: enable CONFIG_HOLES_IN_ZONE for NUMA In-Reply-To: <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> References: <1481706707-6211-1-git-send-email-ard.biesheuvel@linaro.org> <1481706707-6211-3-git-send-email-ard.biesheuvel@linaro.org> Message-ID: <20170206133611.GL16822@rric.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14.12.16 09:11:47, Ard Biesheuvel wrote: > The NUMA code may get confused by the presence of NOMAP regions within > zones, resulting in spurious BUG() checks where the node id deviates > from the containing zone's node id. > > Since the kernel has no business reasoning about node ids of pages it > does not own in the first place, enable CONFIG_HOLES_IN_ZONE to ensure > that such pages are disregarded. > > Signed-off-by: Ard Biesheuvel I would rather see a solution other than making pfn_valid checks more fine grained, but this patch also fixes the issue. So: Acked-by: Robert Richter