All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Welte <laforge@netfilter.org>
To: Andreas Schultz <aschultz@tpip.net>
Cc: Pablo Neira <pablo@netfilter.org>,
	netdev@vger.kernel.org,
	Lionel Gauthier <Lionel.Gauthier@eurecom.fr>,
	openbsc@lists.osmocom.org
Subject: Re: [PATCH net-next v2 1/6] gtp: make GTP sockets in gtp_newlink optional
Date: Mon, 6 Feb 2017 14:51:09 +0100	[thread overview]
Message-ID: <20170206135109.sw5p2yb7cbsa3g37@nataraja> (raw)
In-Reply-To: <20170130163713.17524-2-aschultz@tpip.net>

Hi Andreas,

my kernel coding skills are getting a bit rusty (no pun intended), and
I'll think others on this list are more capable to do so.  But let me at
least provide feedback from the "3GPP / GTP side":

On Mon, Jan 30, 2017 at 05:37:08PM +0100, Andreas Schultz wrote:
> Having both GTPv0-U and GTPv1-U is not always desirable.
> Fallback from GTPv1-U to GTPv0-U was depreciated from 3GPP
> Rel-8 onwards. Post Rel-8 implementation are discuraged
> from listening on the v0 port (see 3GPP TS 29.281, Sect. 1).

I confirm this and I think the related change should be applied.

> A future change will completely decouple the sockets from the
> network device. Till then, at least one of the sockets needs to
> be specified (either v0 or v1), the other is optional.

Makes sense.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

  parent reply	other threads:[~2017-02-06 14:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30 16:37 [PATCH net-next v2 0/6] gtp: misc improvements Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 1/6] gtp: make GTP sockets in gtp_newlink optional Andreas Schultz
2017-02-02 14:10   ` Pablo Neira Ayuso
2017-02-02 14:30     ` Andreas Schultz
2017-02-02 14:32       ` Pablo Neira Ayuso
2017-02-06 13:51   ` Harald Welte [this message]
2017-01-30 16:37 ` [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev Andreas Schultz
2017-02-06 13:55   ` Harald Welte
2017-02-13 14:13     ` Andreas Schultz
2017-02-13 14:51       ` Pablo Neira Ayuso
2017-01-30 16:37 ` [PATCH net-next v2 3/6] gtp: unify genl_find_pdp and prepare for per socket lookup Andreas Schultz
2017-02-02 14:19   ` Pablo Neira Ayuso
2017-02-02 14:27     ` Andreas Schultz
2017-02-02 14:31       ` Pablo Neira Ayuso
2017-02-06 13:56   ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 4/6] gtp: consolidate pdp context destruction into helper Andreas Schultz
2017-02-06 13:58   ` Harald Welte
2017-02-13 14:14     ` Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 5/6] gtp: add socket to pdp context Andreas Schultz
2017-02-02 13:56   ` Pablo Neira Ayuso
2017-02-02 14:12     ` Andreas Schultz
2017-02-02 14:28       ` Pablo Neira Ayuso
2017-02-02 14:38         ` Andreas Schultz
2017-02-02 14:46           ` Pablo Neira Ayuso
2017-02-02 15:07             ` Andreas Schultz
2017-02-06 14:04               ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 6/6] gtp: consolidate gtp socket rx path Andreas Schultz
2017-01-31 18:05 ` [PATCH net-next v2 0/6] gtp: misc improvements David Miller
2017-02-06 13:46   ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206135109.sw5p2yb7cbsa3g37@nataraja \
    --to=laforge@netfilter.org \
    --cc=Lionel.Gauthier@eurecom.fr \
    --cc=aschultz@tpip.net \
    --cc=netdev@vger.kernel.org \
    --cc=openbsc@lists.osmocom.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.