From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:43336 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdBFOe4 (ORCPT ); Mon, 6 Feb 2017 09:34:56 -0500 Date: Mon, 6 Feb 2017 15:34:50 +0100 From: Michal Hocko To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , djwong@kernel.org, "Theodore Ts'o" , Chris Mason , David Sterba , Jan Kara , ceph-devel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, logfs@logfs.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, LKML Subject: Re: [PATCH 1/6] lockdep: allow to disable reclaim lockup detection Message-ID: <20170206143449.GD10298@dhcp22.suse.cz> References: <20170206140718.16222-1-mhocko@kernel.org> <20170206140718.16222-2-mhocko@kernel.org> <20170206142641.GG2267@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170206142641.GG2267@bombadil.infradead.org> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon 06-02-17 06:26:41, Matthew Wilcox wrote: > On Mon, Feb 06, 2017 at 03:07:13PM +0100, Michal Hocko wrote: > > While we are at it also make sure that the radix tree doesn't > > accidentaly override tags stored in the upper part of the gfp_mask. > > > diff --git a/lib/radix-tree.c b/lib/radix-tree.c > > index 9dc093d5ef39..7550be09f9d6 100644 > > --- a/lib/radix-tree.c > > +++ b/lib/radix-tree.c > > @@ -2274,6 +2274,8 @@ static int radix_tree_cpu_dead(unsigned int cpu) > > void __init radix_tree_init(void) > > { > > int ret; > > + > > + BUILD_BUG_ON(RADIX_TREE_MAX_TAGS + __GFP_BITS_SHIFT > 32); > > radix_tree_node_cachep = kmem_cache_create("radix_tree_node", > > sizeof(struct radix_tree_node), 0, > > SLAB_PANIC | SLAB_RECLAIM_ACCOUNT, > > That's going to have a conceptual conflict with some patches I have > in flight. I'll take this part through my radix tree patch collection. This part is not needed for the patch, strictly speaking but I wanted to make the code more future proof. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 6 Feb 2017 15:34:50 +0100 From: Michal Hocko To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , djwong@kernel.org, Theodore Ts'o , Chris Mason , David Sterba , Jan Kara , ceph-devel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, logfs@logfs.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, LKML Subject: Re: [PATCH 1/6] lockdep: allow to disable reclaim lockup detection Message-ID: <20170206143449.GD10298@dhcp22.suse.cz> References: <20170206140718.16222-1-mhocko@kernel.org> <20170206140718.16222-2-mhocko@kernel.org> <20170206142641.GG2267@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170206142641.GG2267@bombadil.infradead.org> Sender: owner-linux-mm@kvack.org List-ID: On Mon 06-02-17 06:26:41, Matthew Wilcox wrote: > On Mon, Feb 06, 2017 at 03:07:13PM +0100, Michal Hocko wrote: > > While we are at it also make sure that the radix tree doesn't > > accidentaly override tags stored in the upper part of the gfp_mask. > > > diff --git a/lib/radix-tree.c b/lib/radix-tree.c > > index 9dc093d5ef39..7550be09f9d6 100644 > > --- a/lib/radix-tree.c > > +++ b/lib/radix-tree.c > > @@ -2274,6 +2274,8 @@ static int radix_tree_cpu_dead(unsigned int cpu) > > void __init radix_tree_init(void) > > { > > int ret; > > + > > + BUILD_BUG_ON(RADIX_TREE_MAX_TAGS + __GFP_BITS_SHIFT > 32); > > radix_tree_node_cachep = kmem_cache_create("radix_tree_node", > > sizeof(struct radix_tree_node), 0, > > SLAB_PANIC | SLAB_RECLAIM_ACCOUNT, > > That's going to have a conceptual conflict with some patches I have > in flight. I'll take this part through my radix tree patch collection. This part is not needed for the patch, strictly speaking but I wanted to make the code more future proof. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Date: Mon, 6 Feb 2017 15:34:50 +0100 Subject: [Cluster-devel] [PATCH 1/6] lockdep: allow to disable reclaim lockup detection In-Reply-To: <20170206142641.GG2267@bombadil.infradead.org> References: <20170206140718.16222-1-mhocko@kernel.org> <20170206140718.16222-2-mhocko@kernel.org> <20170206142641.GG2267@bombadil.infradead.org> Message-ID: <20170206143449.GD10298@dhcp22.suse.cz> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon 06-02-17 06:26:41, Matthew Wilcox wrote: > On Mon, Feb 06, 2017 at 03:07:13PM +0100, Michal Hocko wrote: > > While we are at it also make sure that the radix tree doesn't > > accidentaly override tags stored in the upper part of the gfp_mask. > > > diff --git a/lib/radix-tree.c b/lib/radix-tree.c > > index 9dc093d5ef39..7550be09f9d6 100644 > > --- a/lib/radix-tree.c > > +++ b/lib/radix-tree.c > > @@ -2274,6 +2274,8 @@ static int radix_tree_cpu_dead(unsigned int cpu) > > void __init radix_tree_init(void) > > { > > int ret; > > + > > + BUILD_BUG_ON(RADIX_TREE_MAX_TAGS + __GFP_BITS_SHIFT > 32); > > radix_tree_node_cachep = kmem_cache_create("radix_tree_node", > > sizeof(struct radix_tree_node), 0, > > SLAB_PANIC | SLAB_RECLAIM_ACCOUNT, > > That's going to have a conceptual conflict with some patches I have > in flight. I'll take this part through my radix tree patch collection. This part is not needed for the patch, strictly speaking but I wanted to make the code more future proof. -- Michal Hocko SUSE Labs