From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] p5302: create repositories for index-pack results explicitly
Date: Mon, 6 Feb 2017 15:41:21 +0100 [thread overview]
Message-ID: <20170206144121.hrptyubhtjoyohfl@sigill.intra.peff.net> (raw)
In-Reply-To: <251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de>
On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote:
> Before 7176a314 (index-pack: complain when --stdin is used outside of a
> repo) index-pack silently created a non-existing target directory; now
> the command refuses to work unless it's used against a valid repository.
> That causes p5302 to fail, which relies on the former behavior. Fix it
> by setting up the destinations for its performance tests using git init.
Ah, right. Thanks for catching this.
I think p5302 was wrong to rely on the old behavior, and your patch is
the right fix.
-Peff
prev parent reply other threads:[~2017-02-06 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 11:43 [PATCH] p5302: create repositories for index-pack results explicitly René Scharfe
2017-02-06 14:41 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206144121.hrptyubhtjoyohfl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.