From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: don't fail xfs_extent_busy allocation
Date: Mon, 6 Feb 2017 11:43:18 -0500 [thread overview]
Message-ID: <20170206164318.GF57865@bfoster.bfoster> (raw)
In-Reply-To: <20170204095040.GA18472@lst.de>
On Sat, Feb 04, 2017 at 10:50:40AM +0100, Christoph Hellwig wrote:
> On Fri, Feb 03, 2017 at 10:20:52AM -0500, Brian Foster wrote:
> > On Sun, Jan 29, 2017 at 07:43:38PM +0100, Christoph Hellwig wrote:
> > > We don't just need the structure to track busy extents which can be
> > > avoided with a synchronous transaction, but also to keep track of
> > > pending discard.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > > ---
> >
> > Looks fine, though I wonder if we should create a kmem_cache similar to
> > all of the other log item structures and whatnot...
>
> Using the isolation of a slab cache for such a short lived structure
> seems counter productive.
I was thinking more about the repeated allocation/free of said
structures than lifetime, particularly since we've converted an
opportunistic allocation to a required/sleeping one.
Just a thought though.. looking again, should we have KM_NOFS here as
well?
Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-06 16:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 18:43 improve busy extent handling and add async discard support Christoph Hellwig
2017-01-29 18:43 ` [PATCH 1/4] xfs: don't fail xfs_extent_busy allocation Christoph Hellwig
2017-02-03 15:20 ` Brian Foster
2017-02-04 9:50 ` Christoph Hellwig
2017-02-06 16:43 ` Brian Foster [this message]
2017-02-07 9:42 ` Christoph Hellwig
2017-01-29 18:43 ` [PATCH 2/4] xfs: improve handling of busy extents in the low-level allocator Christoph Hellwig
2017-02-03 15:22 ` Brian Foster
2017-02-04 9:54 ` Christoph Hellwig
2017-02-03 16:22 ` Brian Foster
2017-02-04 9:56 ` Christoph Hellwig
2017-02-06 16:47 ` Brian Foster
2017-02-07 9:43 ` Christoph Hellwig
2017-02-07 13:13 ` Brian Foster
2017-02-07 15:45 ` Christoph Hellwig
2017-01-29 18:43 ` [PATCH 3/4] xfs: improve busy extent sorting Christoph Hellwig
2017-02-03 15:22 ` Brian Foster
2017-02-04 9:58 ` Christoph Hellwig
2017-01-29 18:43 ` [PATCH 4/4] xfs: don't block the log commit handler for discards Christoph Hellwig
2017-02-03 16:22 ` Brian Foster
2017-02-04 9:59 ` Christoph Hellwig
2017-02-06 16:49 ` Brian Foster
2017-02-07 9:50 ` Christoph Hellwig
2017-02-05 17:11 improve busy extent handling and add async discard support V2 Christoph Hellwig
2017-02-05 17:11 ` [PATCH 1/4] xfs: don't fail xfs_extent_busy allocation Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206164318.GF57865@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.