From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752159AbdBFWOP (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Feb 2017 17:14:15 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35158 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751395AbdBFWON (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Feb 2017 17:14:13 -0500
Date: Mon, 6 Feb 2017 23:13:59 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Galbraith <efault@gmx.de>, Oleg Nesterov <oleg@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 00/89] Major reorganization of <linux/sched.h>
Message-ID: <20170206221359.GB7481@gmail.com>
References: <1486387772-18837-1-git-send-email-mingo@kernel.org>
 <CA+55aFxQsTWQdJS+Fio-1S+tPMuYy2+tN9Axpx4Tkzk3-20aCA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFxQsTWQdJS+Fio-1S+tPMuYy2+tN9Axpx4Tkzk3-20aCA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Mon, Feb 6, 2017 at 5:28 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > So 25+ years ago, in Linux-0.01, include/linux/sched.h was already
> > the biggest core kernel header file: [...]
> 
> Ok, so having tried to look through this series I do like it, but I'd be 
> *really* much happier if more of it was just verifiably a semantic no-op.

Yeah - that was the intention.

It's really hard to verify it in an automated fashion I think, in a cross arch 
way. I did a sizeof(task_struct) before/after check on x86 defconfig, which did 
not uncover the extra pointer on CONFIG_TASK_DELAY_ACCT=n, because defconfig has 
that enabled...

On the latest tree I've done a wider test of sizeof(task_struct):

		allnoconfig	defconfig	allmodconfig
  -----------------------------------------------------------
  before:	0x1400		0x19c0		0x3f00
  after:	0x1400		0x19c0		0x3f00

Which seems to support my intention that the series should be an overall invariant 
on 'struct task_struct' semantics.

> There were all those small things in there (Peter pointed out those cpumask 
> things I wouldn't for the life of me have noticed) that were really subtle, and 
> were really hidden by the fact that there was just a lot of non-semantic 
> changes.

I think the ->cpus_allowed bugs Peter noticed are pre-existing - that patch 
doesn't intend to make any semantic changes.

Thanks,

	Ingo