From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbdBFWe1 (ORCPT ); Mon, 6 Feb 2017 17:34:27 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:30948 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdBFWeZ (ORCPT ); Mon, 6 Feb 2017 17:34:25 -0500 Date: Mon, 6 Feb 2017 23:33:24 +0100 From: Willy Tarreau To: Konrad Rzeszutek Wilk Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net, Jan Beulich , David Vrabel Subject: Re: [PATCH 3.10 037/319] xen/pciback: Save xen_pci_op commands before processing it Message-ID: <20170206223324.GC4769@1wt.eu> References: <1486322486-8024-1-git-send-email-w@1wt.eu> <1486322486-8024-8-git-send-email-w@1wt.eu> <20170206143345.GC19124@char.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170206143345.GC19124@char.us.oracle.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2017 at 09:33:45AM -0500, Konrad Rzeszutek Wilk wrote: > On Sun, Feb 05, 2017 at 08:20:24PM +0100, Willy Tarreau wrote: > > From: Konrad Rzeszutek Wilk > > > > commit 8135cf8b092723dbfcc611fe6fdcb3a36c9951c5 upstream. > > You also need: > > commit d159457b84395927b5a52adb72f748dd089ad5e5 > Author: Konrad Rzeszutek Wilk > Date: Thu Feb 11 16:10:24 2016 -0500 > > xen/pciback: Save the number of MSI-X entries to be copied later. > > Commit 8135cf8b092723dbfcc611fe6fdcb3a36c9951c5 (xen/pciback: Save > xen_pci_op commands before processing it) broke enabling MSI-X because > it would never copy the resulting vectors into the response. The > number of vectors requested was being overwritten by the return value > (typically zero for success). Now added as well, thanks Konrad! Willy