From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbdBFXOH (ORCPT ); Mon, 6 Feb 2017 18:14:07 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55088 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbdBFXOD (ORCPT ); Mon, 6 Feb 2017 18:14:03 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2DECD60856 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 6 Feb 2017 15:14:00 -0800 From: Stephen Boyd To: Chris Packham Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Michael Turquette , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] clk: mvebu: Expand mv98dx3236-core-clock support Message-ID: <20170206231400.GM25384@codeaurora.org> References: <20170203034012.29399-1-chris.packham@alliedtelesis.co.nz> <20170203034012.29399-5-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170203034012.29399-5-chris.packham@alliedtelesis.co.nz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03, Chris Packham wrote: > The initial implementation in commit e120c17a70e5 ("clk: mvebu: support > for 98DX3236 SoC") hardcoded a fixed value for the main PLL frequency. > Port code from the Marvell supplied Linux kernel to support different > PLL frequencies and provide clock gating support. > > Signed-off-by: Chris Packham > --- > .../devicetree/bindings/clock/mvebu-core-clock.txt | 7 + > .../bindings/clock/mvebu-gated-clock.txt | 11 ++ > arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 14 +- > drivers/clk/mvebu/Makefile | 2 +- > drivers/clk/mvebu/armada-xp.c | 13 -- > drivers/clk/mvebu/mv98dx3236.c | 144 +++++++++++++++++++++ This mixes dts and clk driver changes. Any chance it can be split up and just have the clk part go through clk tree? Otherwise, I can ack this if you want to take it all through arm-soc? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 4/4] clk: mvebu: Expand mv98dx3236-core-clock support Date: Mon, 6 Feb 2017 15:14:00 -0800 Message-ID: <20170206231400.GM25384@codeaurora.org> References: <20170203034012.29399-1-chris.packham@alliedtelesis.co.nz> <20170203034012.29399-5-chris.packham@alliedtelesis.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170203034012.29399-5-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Packham Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michael Turquette , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 02/03, Chris Packham wrote: > The initial implementation in commit e120c17a70e5 ("clk: mvebu: support > for 98DX3236 SoC") hardcoded a fixed value for the main PLL frequency. > Port code from the Marvell supplied Linux kernel to support different > PLL frequencies and provide clock gating support. > > Signed-off-by: Chris Packham > --- > .../devicetree/bindings/clock/mvebu-core-clock.txt | 7 + > .../bindings/clock/mvebu-gated-clock.txt | 11 ++ > arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 14 +- > drivers/clk/mvebu/Makefile | 2 +- > drivers/clk/mvebu/armada-xp.c | 13 -- > drivers/clk/mvebu/mv98dx3236.c | 144 +++++++++++++++++++++ This mixes dts and clk driver changes. Any chance it can be split up and just have the clk part go through clk tree? Otherwise, I can ack this if you want to take it all through arm-soc? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Mon, 6 Feb 2017 15:14:00 -0800 Subject: [PATCH 4/4] clk: mvebu: Expand mv98dx3236-core-clock support In-Reply-To: <20170203034012.29399-5-chris.packham@alliedtelesis.co.nz> References: <20170203034012.29399-1-chris.packham@alliedtelesis.co.nz> <20170203034012.29399-5-chris.packham@alliedtelesis.co.nz> Message-ID: <20170206231400.GM25384@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/03, Chris Packham wrote: > The initial implementation in commit e120c17a70e5 ("clk: mvebu: support > for 98DX3236 SoC") hardcoded a fixed value for the main PLL frequency. > Port code from the Marvell supplied Linux kernel to support different > PLL frequencies and provide clock gating support. > > Signed-off-by: Chris Packham > --- > .../devicetree/bindings/clock/mvebu-core-clock.txt | 7 + > .../bindings/clock/mvebu-gated-clock.txt | 11 ++ > arch/arm/boot/dts/armada-xp-98dx3236.dtsi | 14 +- > drivers/clk/mvebu/Makefile | 2 +- > drivers/clk/mvebu/armada-xp.c | 13 -- > drivers/clk/mvebu/mv98dx3236.c | 144 +++++++++++++++++++++ This mixes dts and clk driver changes. Any chance it can be split up and just have the clk part go through clk tree? Otherwise, I can ack this if you want to take it all through arm-soc? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project