From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754698AbdBGR62 convert rfc822-to-8bit (ORCPT ); Tue, 7 Feb 2017 12:58:28 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:52932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753497AbdBGR61 (ORCPT ); Tue, 7 Feb 2017 12:58:27 -0500 Date: Tue, 07 Feb 2017 12:58:25 -0500 (EST) Message-Id: <20170207.125825.646803866093568777.davem@davemloft.net> To: stefan.bruens@rwth-aachen.de Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications From: David Miller In-Reply-To: References: <20170206202034.10962-1-stefan.bruens@rwth-aachen.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 07 Feb 2017 08:59:27 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Brüns Date: Mon, 6 Feb 2017 21:20:33 +0100 > > /* Validate the protocol - only support UMTS for now */ > - if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) { > + if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) { ... > + } else if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS_DS) { > + expected_length = SIERRA_NET_LSI_UMTS_DS_STATUS_LEN; If you are now supporting more protocols, that comment is not correct any longer. You therefore need to update it or remove it. Thanks.